Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: sysUsed often called on non-scavenged memory #36603

mknyszek opened this issue Jan 16, 2020 · 0 comments

runtime: sysUsed often called on non-scavenged memory #36603

mknyszek opened this issue Jan 16, 2020 · 0 comments


Copy link

@mknyszek mknyszek commented Jan 16, 2020

In working on #36507, I noticed that one source of regression on Darwin was that sysUsed, as of Go 1.14, is now called on the whole memory allocation, even if just one page of that is actually scavenged. This behavior was already present in Go 1.11, went away in Go 1.12, and is now back.

On systems where sysUsed is a no-op and we rely on the first access "unscavenging" the page, this has no effect, because we're already only unscavenging exactly what's needed. On systems like Darwin and Windows where the "recommit" step is explicit (i.e. sysUsed is not a no-op) this can have a non-trivial impact on performance, since the kernel probably walks over the unscavenged pages for nothing.

This contributed very slightly to the performance regression in #36218, but not enough to cause it to block the 1.14 release.

The fix here is straight-forward: we just need to lower the call of sysUsed in the page allocator where we have complete information over exactly which pages are scavenged. If a given allocation has >50% of its pages scavenged then we can probably just sysUsed the whole thing to save a bit on syscall overheads. This change also makes sense because we already do sysUnused at a fairly low-level part of the page allocator, so bringing sysUsed down there makes sense.

@mknyszek mknyszek added this to the Go1.15 milestone Jan 16, 2020
@mknyszek mknyszek self-assigned this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.