cmd/go: TestNoteReading fails if gold is not installed with gcc 9

[mwhudson]

What version of Go are you using (go version)?

A version of 1.14.3 that has cgo for riscv patched into it

Does this issue reproduce with the latest release?

The code looks the same.

What operating system and processor architecture are you using (go env)?

Ubuntu groovy (the current development series) on riscv

What did you do?

Run the tests.

What did you expect to see?

Tests passing.

What did you see instead?

--- FAIL: TestNoteReading (21.83s)
    note_test.go:23: running testgo [build -ldflags -buildid=TestNoteReading-Build-ID -o /tmp/cmd-go-test-248563288/gotest651359243/hello.exe /tmp/cmd-go-test-248563288/gotest651359243/hello.go]
    note_test.go:39: running testgo [build -ldflags -buildid=TestNoteReading-Build-ID -linkmode=external -o /tmp/cmd-go-test-248563288/gotest651359243/hello2.exe /tmp/cmd-go-test-248563288/gotest651359243/hello.go]
    note_test.go:52: running testgo [build -ldflags -buildid=TestNoteReading-Build-ID -linkmode=external -extldflags=-fuse-ld=gold -o /tmp/cmd-go-test-248563288/gotest651359243/hello3.exe /tmp/cmd-go-test-248563288/gotest651359243/hello.go]
    note_test.go:52: standard error:
    note_test.go:52: # command-line-arguments
        /<<PKGBUILDDIR>>/pkg/tool/linux_riscv64/link: running gcc failed: exit status 1
        collect2: fatal error: cannot find ‘ld’
        compilation terminated.
        
        
    note_test.go:60: building hello binary: exit status 2

The test skips if there is "cannot find 'ld'" in the output but at some point in the last couple of years it looks like gcc has switched to "smart quotes", breaking this.

[gopherbot]

Change https://golang.org/cl/234380 mentions this issue: cmd/go: accept smart quotes when checking for missing gold in TestNoteReading