Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path/filepath: revert "path/filepath: fix EvalSymLink documentation" #40178

Closed
wants to merge 3 commits into from

Conversation

ericwj
Copy link

@ericwj ericwj commented Jul 12, 2020

Revert "path/filepath: fix EvalSymLink documentation"

This reverts commit c22d0356040e26f4bbd4198e6622261b589322cf.

This documentation change is the best solution for EvalSymLinks short of deleting this API altogether.

EvalSymLinks is not suitable on any operating system because it unconditionally undoes indirections without being aware of the problems that these indirections solve.

This is a violation of the software engineering principle which states:

> Any problem in software can be solved by adding another layer of indirection.
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 12, 2020
@gopherbot
Copy link

This PR (HEAD: c26d2f0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/242178 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants