net: some tests are skipped on Windows due to os.Getuid() always returns -1

[zhangyoufu]

Does this issue reproduce with the latest release?

Yes

What did you do?

go test -v net

What did you expect to see?

Run all tests that are applicable.

What did you see instead?

=== RUN   TestIPConnLocalName
--- PASS: TestIPConnLocalName (0.00s)
    iprawsock_test.go:93: skipping ip4:icmp test
    iprawsock_test.go:93: skipping ip4:icmp test
    iprawsock_test.go:93: skipping ip4:icmp test

=== RUN   TestIPConnRemoteName
--- SKIP: TestIPConnRemoteName (0.00s)
    iprawsock_test.go:109: ip:tcp test

=== RUN   TestIPv6MulticastListener
--- SKIP: TestIPv6MulticastListener (0.00s)
    listen_test.go:619: must be root

Related code

go/src/net/platform_test.go

Lines 34 to 48 in d5e1b7c

	// testableNetwork reports whether network is testable on the current
	// platform configuration.
	func testableNetwork(network string) bool {
	ss := strings.Split(network, ":")
	switch ss[0] {
	case "ip+nopriv":
	case "ip", "ip4", "ip6":
	switch runtime.GOOS {
	case "plan9":
	return false
	default:
	if os.Getuid() != 0 {
	return false
	}
	}

go/src/net/listen_test.go

Lines 603 to 620 in d3a411b

	// TestIPv6MulticastListener tests both single and double listen to a
	// test listener with same address family, same group address and same
	// port.
	func TestIPv6MulticastListener(t *testing.T) {
	testenv.MustHaveExternalNetwork(t)
	switch runtime.GOOS {
	case "plan9":
	t.Skipf("not supported on %s", runtime.GOOS)
	case "solaris", "illumos":
	t.Skipf("not supported on solaris or illumos, see issue 7399")
	}
	if !supportsIPv6() {
	t.Skip("IPv6 is not supported")
	}
	if os.Getuid() != 0 {
	t.Skip("must be root")
	}

[networkimprov]

@gopherbot add OS-Windows

cc @alexbrainman

[alexbrainman]

@zhangyoufu that is unfortunately how things are: os.Getuid is not implemented on Windows, and we have to skip tests that require os.Getuid to work. We all know that. Why did you create this issue? Do you propose to fix os.Getuid? Do you propose something else?

Thank you.

Alex

[zhangyoufu]

Do you propose to fix os.Getuid?

No. I think that uid and sid are totally different. We can't just map SYSTEM/Administrators to uid 0.

Why did you create this issue?

I think that the some test cases can be run on Windows, instead of just skip because os.Getuid is not implemented.

Do you propose something else?

I propose that these test cases should not consult os.Getuid on Windows. We can have helper functions in testenv, judging whether we have enough privilege to perform such test cases.

[alexbrainman]

I propose that these test cases should not consult os.Getuid on Windows. We can have helper functions in testenv, judging whether we have enough privilege to perform such test cases.

Sounds good to me. But I don't plan to work on it. I will be happy to review someone else's code.

Alex

[cagedmantis]

/cc @mikioh