database/sql: close driver.Connector if it implements io.Closer #41710
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 04bfcb1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/258360 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: edd35d7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/258360 to see it. Tip: You can toggle comments from me using the |
|
Message from Emmanuel Odeke: Patch Set 2: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=54ecb348 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Gobot Gobot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Ivan Trubach: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=54ecb348 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Ivan Trubach: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Daniel Theophanes: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Emmanuel Odeke: Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=61d06b53 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 3: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 3: TryBot-Result-1 1 of 21 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
This change allows driver implementations to manage resources in driver.Connector, e.g. to share the same underlying database handle between multiple connections. That is, it allows embedded databases with in-memory backends like SQLite and Genji to safely release the resources once the sql.DB is closed. This makes it possible to address oddities with in-memory stores in SQLite and Genji drivers without introducing too much complexity in the driver implementations. See also: - mattn/go-sqlite3#204 - mattn/go-sqlite3#511 - chaisql/chai#210
|
This PR (HEAD: 962c785) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/258360 to see it. Tip: You can toggle comments from me using the |
|
Message from Ivan Trubach: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
odeke-em
changed the title
|
Message from Emmanuel Odeke: Patch Set 4: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=162dfdf5 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Emmanuel Odeke: Patch Set 5: Run-TryBot+1 Code-Review+2 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
|
Message from Go Bot: Patch Set 5: TryBots beginning. Status page: https://farmer.golang.org/try?commit=99666900 Please don’t reply on this GitHub thread. Visit golang.org/cl/258360. |
This change allows driver implementations to manage resources in driver.Connector, e.g. to share the same underlying database handle between multiple connections. That is, it allows embedded databases with in-memory backends like SQLite and Genji to safely release the resources once the sql.DB is closed. This makes it possible to address oddities with in-memory stores in SQLite and Genji drivers without introducing too much complexity in the driver implementations. See also: - mattn/go-sqlite3#204 - mattn/go-sqlite3#511 - chaisql/chai#210 Fixes #41790 Change-Id: Idbd19763134438ed38288b9d44f16608e4e97fd7 GitHub-Last-Rev: 962c785 GitHub-Pull-Request: #41710 Reviewed-on: https://go-review.googlesource.com/c/go/+/258360 Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Daniel Theophanes <kardianos@gmail.com> Trust: Emmanuel Odeke <emmanuel@orijtech.com> Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com> TryBot-Result: Go Bot <gobot@golang.org>
|
This PR is being closed because golang.org/cl/258360 has been merged. |
This change allows driver implementations to manage resources in
driver.Connector, e.g. to share the same underlying database handle
between multiple connections. That is, it allows embedded databases
with in-memory backends like SQLite and Genji to safely release the
resources once the sql.DB is closed.
This makes it possible to address oddities with in-memory stores in
SQLite and Genji drivers without introducing too much complexity in
the driver implementations.
See also:
Fixes #41790