Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: use the memoize cache for workspace directories #41765

Closed
stamblerre opened this issue Oct 2, 2020 · 1 comment
Closed

x/tools/gopls: use the memoize cache for workspace directories #41765

stamblerre opened this issue Oct 2, 2020 · 1 comment
Assignees

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 2, 2020

Also, only change workspace directories when files are saved. Otherwise, we will constantly send notifications while a replace directive is being typed and the go.mod doesn't parse.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Oct 2, 2020
@stamblerre stamblerre self-assigned this Oct 7, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Oct 22, 2020

This is no longer relevant with the changes in https://golang.org/cl/261237.

@stamblerre stamblerre closed this Oct 22, 2020
@stamblerre stamblerre removed this from the gopls/vscode-go milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants