time: add Time.IsDST() to check if its Location is in Daylight Savings Time #42103

jufemaiz · 2020-10-21T01:51:17Z

gopherbot · 2020-10-21T02:02:34Z

This PR (HEAD: 4a09563) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-21T02:04:28Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-21T13:37:25Z

Message from Matt Layher:

Patch Set 1: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-11T19:15:28Z

Message from Matt Layher:

Patch Set 1: Run-TryBot+1 -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-11T19:15:29Z

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5fa535c2

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-11T19:17:27Z

Message from Go Bot:

Patch Set 1:

Build is still in progress...
This change failed on misc-compile-darwinarm64:
See https://storage.googleapis.com/go-build-log/5fa535c2/misc-compile-darwinarm64_7402c16e.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-11T19:27:11Z

Message from Go Bot:

Patch Set 1: TryBot-Result-1

1 of 21 TryBots failed:
Failed on misc-compile-darwinarm64: https://storage.googleapis.com/go-build-log/5fa535c2/misc-compile-darwinarm64_7402c16e.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-11-11T20:01:49Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-12T02:19:12Z

Message from Emmanuel Odeke:

Patch Set 1: Trust+1

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T01:18:20Z

This PR (HEAD: 8997f16) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T02:38:43Z

This PR (HEAD: f5f7370) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T03:57:17Z

Message from Emmanuel Odeke:

Patch Set 6: Code-Review+1 Trust+1

(10 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T04:12:42Z

Message from Emmanuel Odeke:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T04:12:43Z

Message from Go Bot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=60c20ee2

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T05:03:31Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

…th labelling

gopherbot · 2021-03-15T05:24:40Z

This PR (HEAD: 0b6b294) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T05:28:41Z

This PR (HEAD: dc6ca15) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T05:32:25Z

Message from Joel Courtney:

Patch Set 7:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T05:38:13Z

Message from Emmanuel Odeke:

Patch Set 8: Run-TryBot+1 Code-Review+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T05:38:14Z

Message from Go Bot:

Patch Set 8:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=06d179fe

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T06:30:52Z

Message from Go Bot:

Patch Set 8: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

solaris-amd64-oraclerel
windows-amd64-2016

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T10:04:00Z

Message from Tobias Klauser:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T10:12:26Z

This PR (HEAD: ce1e9e7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T10:17:26Z

Message from Joel Courtney:

Patch Set 9:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T10:17:27Z

Message from Tobias Klauser:

Patch Set 9: Run-TryBot+1 Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T10:17:27Z

Message from Go Bot:

Patch Set 9:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=be9d65c4

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T11:05:24Z

Message from Go Bot:

Patch Set 9: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

solaris-amd64-oraclerel
windows-amd64-2016

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T13:17:42Z

Message from Emmanuel Odeke:

Patch Set 9: Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T22:07:15Z

This PR (HEAD: 87d4373) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T22:14:08Z

Message from Ian Lance Taylor:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T22:14:08Z

Message from Ian Lance Taylor:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T22:28:26Z

Message from Joel Courtney:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T22:28:35Z

This PR (HEAD: bbfa921) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/264077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-15T22:42:34Z

Message from Ian Lance Taylor:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T22:42:34Z

Message from Go Bot:

Patch Set 11:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=7bb982de

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T23:41:35Z

Message from Go Bot:

Patch Set 11: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

solaris-amd64-oraclerel
windows-amd64-2016

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T23:41:36Z

Message from Emmanuel Odeke:

Patch Set 11: Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-15T23:49:16Z

Message from Rob Pike:

Patch Set 11: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/264077.
After addressing review feedback, remember to publish your drafts!

…s Time Fixes #42102 Change-Id: I2cd2fdf67c794c3e99ed1c24786f7f779da73962 GitHub-Last-Rev: bbfa921 GitHub-Pull-Request: #42103 Reviewed-on: https://go-review.googlesource.com/c/go/+/264077 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Rob Pike <r@golang.org> Trust: Emmanuel Odeke <emmanuel@orijtech.com>

gopherbot · 2021-03-16T00:07:04Z

This PR is being closed because golang.org/cl/264077 has been merged.

Feature: IsDST on time.Location

4a09563

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 21, 2020

Merge branch 'master' into proposal/time-isdst

8997f16

jufemaiz changed the title ~~time: add IsDST function on a Location for a given Time~~ time: add Time.IsDST() bool method Mar 15, 2021

jufemaiz marked this pull request as draft March 15, 2021 01:20

Chore: updated based on feedback

f5f7370

jufemaiz marked this pull request as ready for review March 15, 2021 02:38

odeke-em changed the title ~~time: add Time.IsDST() bool method~~ time: add Time.IsDST() to check if is Location is within a Daylight Savings Time zone Mar 15, 2021

odeke-em changed the title ~~time: add Time.IsDST() to check if is Location is within a Daylight Savings Time zone~~ time: add Time.IsDST() to check if its Location is in Daylight Savings Time Mar 15, 2021

Bugfix: corrected the use tests and added note on hemisphere issue wi…

0b6b294

…th labelling

Additional feedback

dc6ca15

PR feedback from Tobias Klauser

ce1e9e7

Feedback: missed assertion

87d4373

PR feedback from Ian Lance Taylor re CONTRIBUTORS

bbfa921

gopherbot closed this Mar 16, 2021

wneessen mentioned this pull request Mar 28, 2021

Introducing -24 and -l flags oz/tz#20

Closed

time: add Time.IsDST() to check if its Location is in Daylight Savings Time #42103

time: add Time.IsDST() to check if its Location is in Daylight Savings Time #42103

Conversation

jufemaiz commented Oct 21, 2020

gopherbot commented Oct 21, 2020

gopherbot commented Oct 21, 2020

gopherbot commented Oct 21, 2020

gopherbot commented Nov 11, 2020

gopherbot commented Nov 11, 2020

gopherbot commented Nov 11, 2020

gopherbot commented Nov 11, 2020

gopherbot commented Nov 11, 2020

gopherbot commented Mar 12, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 15, 2021

gopherbot commented Mar 16, 2021