Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: export ErrProcessDone variable in windows and plan9 #42313

Closed
wants to merge 2 commits into from
Closed

os: export ErrProcessDone variable in windows and plan9 #42313

wants to merge 2 commits into from

Conversation

alwindoss
Copy link
Contributor

@alwindoss alwindoss commented Oct 31, 2020

Exposes ErrProcessDone variable in windows and plan9
also returns this error code instead of
errors.New("os: process already finished")

Fixes #42311

Signed-off-by: Alwin Doss <alwindoss84@gmail.com>
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 31, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 44b2bd8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/266997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: Alwin Doss <alwindoss84@gmail.com>
@gopherbot
Copy link
Contributor

This PR (HEAD: 2153e0d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/266997 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Alwin Doss:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3: Run-TryBot+1 Trust+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=6e02c328


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alwin Doss:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

Build is still in progress...
This change failed on linux-amd64-longtest:
See https://storage.googleapis.com/go-build-log/6e02c328/linux-amd64-longtest_3f55cdad.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result-1

2 of 22 SlowBots failed:
Failed on linux-amd64-longtest: https://storage.googleapis.com/go-build-log/6e02c328/linux-amd64-longtest_3f55cdad.log
Failed on windows-amd64-longtest: https://storage.googleapis.com/go-build-log/6e02c328/windows-amd64-longtest_b55ddef3.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alwin Doss:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Patch Set 3 was rebased


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=2bd62b94


Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4: TryBot-Result+1

SlowBots are happy.
SlowBot builds that ran:

  • linux-amd64-longtest
  • windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/266997.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 3, 2020
Exposes ErrProcessDone variable in windows and plan9
also returns this error code instead of
errors.New("os: process already finished")

Fixes #42311

Change-Id: Ie807b6526e7b6c27636e6bffe5ff0c904b319be4
GitHub-Last-Rev: 2153e0d
GitHub-Pull-Request: #42313
Reviewed-on: https://go-review.googlesource.com/c/go/+/266997
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/266997 has been merged.

@gopherbot gopherbot closed this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os: ErrProcessDone not defined on windows
2 participants