Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: set experimentalPackageCacheKey to true by default #42692

Closed
stamblerre opened this issue Nov 18, 2020 · 1 comment
Closed

x/tools/gopls: set experimentalPackageCacheKey to true by default #42692

stamblerre opened this issue Nov 18, 2020 · 1 comment
Assignees
@stamblerre
Labels
Tools gopls
Milestone
gopls/v0.5.4

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 18, 2020

This is an experimental setting that does not appear to have had any negative consequences (no user bug reports that can be attributed to it). We should enable it by default in the next release.

/cc @findleyr
@stamblerre stamblerre added this to the gopls/v0.5.4 milestone Nov 18, 2020
@stamblerre stamblerre changed the title x/tools/gopls: set experimentalCacheKey to true by default x/tools/gopls: set experimentalPackageCacheKey to true by default Nov 18, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 19, 2020

Change https://golang.org/cl/271478 mentions this issue: internal/lsp/source: set experimentalPackageCacheKey to true by default
@stamblerre stamblerre self-assigned this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stamblerre stamblerre

Labels
Tools gopls
Projects
None yet
Milestone
gopls/v0.5.4
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot
You can’t perform that action at this time.