net/http/cgi: test failures due to ServeHTTP timeouts #43624
Labels
FrozenDueToAge
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
Testing
An issue that has been verified to require only test changes, not just a test failure.
Milestone
2021-01-08T22:55:41-59bfc18/windows-arm-zx2c4
2020-05-01T21:57:29-be08e10/plan9-amd64-9front
It looks like the test hard-codes a 5-second timeout for this operation, ignoring the actual timeout for the test:
go/src/net/http/cgi/integration_test.go
Lines 126 to 127 in 846dce9
It isn't clear to me why this test is using its own timeout logic at all — if the test deadlocks for some reason, it seems more useful to get a stack dump instead of a
killed process
message. Probably this timeout code should just be removed, and the call toh.ServeHTTP
should be performed synchronously in the test function (instead of in a separate goroutine).CC @zx2c4 @golang/release
The text was updated successfully, but these errors were encountered: