net/http/httputil: add a ModifyRequest method to ReverseProxy #44535
+97
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Director() method doesn't allow reporting an error and/or stop
processing a request. This can be worked around with middleware, that
brings about a lot of ceremony and makes ReverseProxy hard to use on
its own.
The proposed patch deprecates the Director() method and adds a new
ModifyRequest() method, that supports returning an error. Similar to
ModifyResponse(), if an error is returned the normal flow is stopped
and the error handler is called instead.
If no ModifyRequest is given, the old Director() method is called
instead and considered to always succeed, to preserve backwards
compatibility (including crashing if Director is also empty).
Issue #45469