Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http/httputil: add a ModifyRequest method to ReverseProxy #44535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ct16k
Copy link

@ct16k ct16k commented Feb 23, 2021

The Director() method doesn't allow reporting an error and/or stop
processing a request. This can be worked around with middleware, that
brings about a lot of ceremony and makes ReverseProxy hard to use on
its own.

The proposed patch deprecates the Director() method and adds a new
ModifyRequest() method, that supports returning an error. Similar to
ModifyResponse(), if an error is returned the normal flow is stopped
and the error handler is called instead.

If no ModifyRequest is given, the old Director() method is called
instead and considered to always succeed, to preserve backwards
compatibility (including crashing if Director is also empty).

Issue #45469

ModifyRequest() method

The Director() method doesn't allow reporting an error and/or stop
processing a request. This can be worked around with middleware, that
brings about a lot of ceremony and makes ReverseProxy hard to use on
its own.

The proposed patch deprecates the Director() method and adds a new
ModifyRequest() method, that supports returning an error. Similar to
ModifyResponse(), if an error is returned the normal flow is stopped
and the error handler is called instead.

If no ModifyRequest is given, the old Director() method is called
instead and considered to always succeed, to preserve backwards
compatibility (including crashing if Director is also empy).
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 23, 2021
@gopherbot
Copy link

This PR (HEAD: 964d6b1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/295390 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/295390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Damien Neil:

Patch Set 2:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/295390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Damien Neil:

Patch Set 2: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/295390.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Damien Neil:

Patch Set 2: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/295390.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants