database/sql: error not wrapped

[eduardisimo203]

What version of Go are you using (go version)?

$ go version
go version go1.16 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GOARCH="amd64"

GOHOSTOS="darwin"

What did you do?

Happened to use one of the SQL Exec methods and happened to get error at

go/src/database/sql/convert.go

Line 194 in 0e85fd7

return nil, fmt.Errorf("sql: converting argument %s type: %v", describeNamedValue(nv), err)

The error does not get wrapped (with "%w"), so cannot use errors.Is()

What did you expect to see?

What did you see instead?

[seankhliao]

Which errors would this allow comparing to? And what would the calling code do differently when it can inspect the error?

[eduardisimo203]

I believe the error is returned by our custom Scan(src interface{}) error method. And when we try to see if that error occurred, it, of course, fails because it's not wrapped.

[gopherbot]

Change https://golang.org/cl/333990 mentions this issue: database/sql: explicitly wrap error message in convertAssignRows