runtime:fix wrong comment #44786
Open
runtime:fix wrong comment #44786
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
This PR (HEAD: d9b37ba) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/298689 to see it. Tip: You can toggle comments from me using the |
Mifrill
reviewed
Nov 9, 2023
Comment on lines
+824
to
+828
| // argument 'size' is always size rounded up to the next malloc size class, | ||
| // argument dataSize is always equal typ.size or typ.size * N (when typ is | ||
| // array and N is the size of array) except in the case of | ||
| // allocating a defer block, in which case | ||
| // dataSize is sizeof(_defer{}) (at least 6 words) and 'size' may be |
There was a problem hiding this comment.
Suggested change
| // argument 'size' is always size rounded up to the next malloc size class, | |
| // argument dataSize is always equal typ.size or typ.size * N (when typ is | |
| // array and N is the size of array) except in the case of | |
| // allocating a defer block, in which case | |
| // dataSize is sizeof(_defer{}) (at least 6 words) and 'size' may be | |
| // The argument 'size' is always the size rounded up to the next malloc size class. | |
| // The argument 'dataSize' is always equal to typ.size or typ.size * N | |
| // (when typ is an array and N is the size of the array), | |
| // except in the case of allocating a defer block. | |
| // In this case, 'dataSize' is sizeof(_defer{}) (at least 6 words), and 'size' may be... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original comment may be wrong
the dataSize is the size of new object (except allocating a defer block
and the arguments size is the actually rounded to the next malloc size class