Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/image: support for WebP Encoding #45121

Open
ainsleyclark opened this issue Mar 19, 2021 · 6 comments
Open

x/image: support for WebP Encoding #45121

ainsleyclark opened this issue Mar 19, 2021 · 6 comments

Comments

@ainsleyclark
Copy link

@ainsleyclark ainsleyclark commented Mar 19, 2021

Hi there,

Currently we are able to decode webp images, which is great. But why can't we encode them?

Given that PSI is such a crucial factor for getting websites to rank, it's important that any server should be able to convert and serve webp images.

I have to jump through hoops at the moment and use the webp executable which is far from ideal.

Please please add an encoder!

Many many thanks.

@ainsleyclark ainsleyclark changed the title Support for WebP Encoding x/image Support for WebP Encoding Mar 19, 2021
@gopherbot gopherbot added this to the Unreleased milestone Mar 19, 2021
@ALTree ALTree changed the title x/image Support for WebP Encoding x/image: support for WebP Encoding Mar 19, 2021
@ALTree
Copy link
Member

@ALTree ALTree commented Mar 19, 2021

Loading

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 19, 2021

A WebP encoder would be a lot of work. If someone wants to write one, that would be great. But as far as I know nobody is working on that.

Loading

@ainsleyclark
Copy link
Author

@ainsleyclark ainsleyclark commented Mar 19, 2021

That's a shame, whilst I understand that it may be a bit of work, it feels like it should be out of the box considering webp and go are both made by you guys!

Adding C bindings when converting to webp using third party packages can be messy, as well as using the executables.

I would love to offer a hand to contribute to the /x/image library but wouldn't know where to start.

Loading

@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Mar 19, 2021

I understand that it may be a bit of work

It's not a bit of work. As Ian said, it's a lot of work. :-)

Loading

@DemiMarie
Copy link

@DemiMarie DemiMarie commented Mar 22, 2021

That's a shame, whilst I understand that it may be a bit of work, it feels like it should be out of the box considering webp and go are both made by you guys!

Adding C bindings when converting to webp using third party packages can be messy, as well as using the executables.

The good news is that image encoding is much less of a security minefield than image decoding is, simply because the input format (a bitmap) is far, far simpler.

That said, have you considered ImageFlow? It’s free software (AGPL) available as both a daemon and a library. Commercial licenses are also available.

Loading

@ainsleyclark
Copy link
Author

@ainsleyclark ainsleyclark commented Aug 27, 2021

Hi there,

Thank you for the comments, I'm just wondering if this is being considered for a feature request?

Many thanks.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants