Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: format all shell scripts in Go repo with shfmt #45125

Closed
wants to merge 8 commits into from
Closed

all: format all shell scripts in Go repo with shfmt #45125

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2021

Updates #45124

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 19, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 9e07fdc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/303272 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@ghost ghost changed the title all: Fixed bash all: format all shell scripts in Go repo with shfmt Mar 20, 2021
@gopherbot
Copy link
Contributor

Message from Zik Aeroh:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Prajwal Koirala:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Prajwal Koirala:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Prajwal Koirala:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 15f69ca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/303272 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 4d2346f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/303272 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: dc69cac) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/303272 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Zik Aeroh:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Prajwal Koirala:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Code-Review-2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Prajwal Koirala:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Prajwal Koirala:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/303272.
After addressing review feedback, remember to publish your drafts!

@ghost ghost closed this Nov 8, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gopherbot