New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: use consistent case in URL in names #45294

Closed

JuwanXu wants to merge 2 commits into golang:master from JuwanXu:master

Contributor

JuwanXu commented Mar 30, 2021 •

edited

No description provided.

JuwanXu added 2 commits

March 30, 2021 14:23


          net/http: fix typos

7b75064


          Merge pull request #1 from JuwanXu/fix-typos

bb0861b

net/http: fix typos

google-cla bot added the cla: yes label

gopherbot commented Mar 30, 2021

This PR (HEAD: bb0861b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/305772 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot commented Mar 30, 2021

Message from Ben Shi:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 30, 2021

Message from 徐志伟:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 30, 2021

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

JuwanXu changed the title ~~net/http: fix typos~~ net/http: use consistent case in URL in names

gopherbot commented Mar 30, 2021

Message from 徐志伟:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 31, 2021

Message from Ben Shi:

Patch Set 3: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 31, 2021

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0cd84be7

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 31, 2021

Message from Go Bot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          net/http: use consistent case in URL in names

c93cd86

Change-Id: Iff5074713e1a4484c04b8628fb2611b6d4e154c7
GitHub-Last-Rev: bb0861b
GitHub-Pull-Request: #45294
Reviewed-on: https://go-review.googlesource.com/c/go/+/305772
Reviewed-by: Ben Shi <powerman1st@163.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ben Shi <powerman1st@163.com>
TryBot-Result: Go Bot <gobot@golang.org>

gopherbot commented Mar 31, 2021

Message from Ian Lance Taylor:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/305772.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Mar 31, 2021

This PR is being closed because golang.org/cl/305772 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment