proposal: cmd/go: message about deprecated modules should not be a warning by default

[theckman]

Context

The go command currently reports deprecation notices as a warning[0], even if that module version is still fully supported but the author and the Deprecation is informing consumers of a new major version (as we have no other mechanisms to communicate information to consumers).

0:

go/src/cmd/go/internal/modget/get.go

Line 1601 in 814c5ff

fmt.Fprintf(os.Stderr, "go: warning: module %s is deprecated: %s\n", mm.m.Path, mm.message)

Proposal

This proposal is to remove the word warning from the message that's printed when showing the deprecation, and leave it up to the Module author to provide the context around the severity in the deprecation message itself.

[seankhliao]

cc @bcmills @jayconrod @matloob

[peterbourgon]

Strong +1. I was surprised to see the word "warning" in the mesasging, because it was deliberately not part of the proposal.

[gopherbot]

Change https://golang.org/cl/321649 mentions this issue: cmd/go: remove warning from module deprecation notice printing

[jayconrod]

This seems okay? If everyone's fine with this, I think we should go ahead and merge that CL rather than go through the proposal process.

[bcmills]

Agreed — I think we should just do this rather than send it through the proposal process. (It's just a rewording in the go command's output, so the proposal process seems too heavy, and since we don't guarantee output stability for the go command there are no backward- or forward-compatibility issues to worry about.)

[theckman]

Works for me. I only filed it as a proposal as I wasn't sure when that decision had been made to call it a warning, relative to the original proposal, or if it was something that had mistakenly been added during the implementation.

[jayconrod]

Ok sounds good. Submitted the CL, thanks for sending that.

I think I used "warning" just because retraction uses similar language, and the code that handles deprecation is close to that.