/ go Public
x/build: gccgo builder for testing $GOROOT/test directory #46726
x/build issues (builders, bots, dashboards)
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
The $GOROOT/test directory contains test files that are also tested by gccgo, but that we don't regularly test against gccgo. That means:
@ianlancetaylor has to periodically spend a bunch of time updating tests for gccgo. E.g., these CLs span about 3 weeks from late Nov 2020 to mid Dec 2020: b94346e, d6abf29, a45e12f, 848dff6, 73e796c, 58768ae, bacb307, 6d2b335, ce61ccc, be10af7, 5a25a3f, 685a322, 731bb54,
When updating existing tests, folks are scared to ever remove pattern alternatives from existing regexps for fear of breaking gccgo. For example, test/fixedbugs/issue11326.go has tests with 5 alternatives, even though we've only ever supported 3 type checkers (gc, gccgo, and go/types):
Lines 21 to 25 in 1ed0d12
Additionally, the 5th alternative "overflows" is a substring of alternatives 1 and 4, so they needn't be included anymore.
I think both of these issues would be helped if we had a builder (and slowbot) that ran the $GOROOT/test tests in gccgo mode.
/cc @ianlancetaylor @golang/release
The text was updated successfully, but these errors were encountered: