Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: TestExtraFiles failures with 'leaked parent file' on freebsd-amd64-race starting 2021-11-05 #49500

Closed
bcmills opened this issue Nov 10, 2021 · 7 comments
Closed

os/exec: TestExtraFiles failures with 'leaked parent file' on freebsd-amd64-race starting 2021-11-05 #49500

bcmills opened this issue Nov 10, 2021 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-FreeBSD release-blocker WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 10, 2021 

--- FAIL: TestExtraFiles (0.52s)
    exec_test.go:705: Run: exit status 1
        --- stdout:
        leaked parent file. fd = 88; want 87
        readlink("/proc/self/fd/87") = "", readlink /proc/self/fd/87: no such file or directory
        USER     CMD          PID   FD MOUNT      INUM MODE         SZ|DV R/W
        root     read3.exe   8324 text /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   wd /        808966 drwxr-xr-x     512  r
        root     read3.exe   8324 root /             2 drwxr-xr-x     512  r
        root     read3.exe   8324    0 /dev         19 crw-rw-rw-    null  r
        root     read3.exe   8324    1* pipe fffff800060a3758 <-> fffff800060a35f0      0 rw
        root     read3.exe   8324    2* pipe fffff8011e381d48 <-> fffff8011e381be0      0 rw
        root     read3.exe   8324    3 -        723335 -rw-------      12 rw
        root     read3.exe   8324    4 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324    5 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324    6 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324    7 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324    8 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324    9 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   10 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   11 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   12 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   13 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   14 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   15 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   16 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   17 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   18 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   19 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   20 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   21 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   22 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   23 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   24 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   25 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   26 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   27 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   28 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   29 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   30 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   31 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   32 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   33 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   34 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   35 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   36 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   37 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   38 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   39 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   40 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   41 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   42 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   43 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   44 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   45 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   46 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   47 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   48 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   49 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   50 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   51 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   52 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   53 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   54 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   55 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   56 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   57 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   58 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   59 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   60 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   61 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   62 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   63 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   64 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   65 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   66 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   67 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   68 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   69 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   70 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   71 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   72 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   73 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   74 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   75 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   76 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   77 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   78 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   79 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   80 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   81 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   82 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   83 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   84 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   85 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   86 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   87
        root     read3.exe   8324   88 /        883099 -rwxr-xr-x  2047910  r
        root     read3.exe   8324   89* pipe fffff8011e0dc8e8 <-> fffff8011e0dca50      0 rw
        root     read3.exe   8324   90* pipe fffff8011e0dca50 <-> fffff8011e0dc8e8      0 rw
        root     read3.exe   8324   92* pipe fffff80006596be0 <-> fffff80006596d48      0 rw
        --- stderr:
FAIL
FAIL	os/exec	1.446s

greplogs --dashboard -md -l -e 'leaked parent file' --since=2021-01-01

2021-11-10T05:08:25-17980df/freebsd-amd64-race
2021-11-09T19:01:30-f59d36d/freebsd-amd64-race
2021-11-05T22:26:07-d3a80c7/freebsd-amd64-race
2021-11-05T21:28:07-ad6ce55/freebsd-amd64-race
2021-11-05T20:59:32-71559a6/freebsd-amd64-race

(See previously #42431, #25628, #7531, #5073.)
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD release-blocker labels Nov 10, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 10, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Nov 10, 2021

Marking as release-blocker for Go 1.18 because this appears to be a regression as of Nov. 5.

@bcmills
Copy link
Contributor Author

bcmills commented Nov 10, 2021

@ianlancetaylor, any ideas? It seems curious to me that these are all on the -race builder...

@bcmills bcmills mentioned this issue Nov 11, 2021
Closed
@mknyszek
Copy link
Contributor

I'll investigate this.

@mknyszek mknyszek self-assigned this Nov 15, 2021
@mknyszek
Copy link
Contributor

Given that I reproduced #49533 (I think) while running this test, I wonder if its related...

@prattmic
Copy link
Member

FWIW, I got one of these failures in ~15s at tip, and none for ~45min with https://golang.org/cl/364035, so this may be a duplicate.

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Nov 17, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Nov 17, 2021

Marking WaitingForInfo to watch the builders for failures after CL 364035. (I suspect this is fixed.)

@aclements
Copy link
Member

It looks like this was indeed fixed:

$ greplogs --dashboard -l -e 'leaked parent file' --since=2021-01-01 | findflakes -paths
First observed 71559a6 05 Nov 20:59 2021 (2849 commits ago)
Last observed  560dc97 15 Nov 21:21 2021 (1561 commits ago)
0.07% chance failure is still happening
0.47% failure probability (7 of 1289 commits)

Closing.

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 OS-FreeBSD release-blocker WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@mknyszek @prattmic @aclements @bcmills @gopherbot