-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: add support for /etc/hosts aliases using go resolver #51004
Conversation
This PR (HEAD: c9c2946) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Damien Neil: Patch Set 2: Run-TryBot+1 Code-Review+1 Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 2: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
This PR (HEAD: ed5b644) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 1c5b1a0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Mateusz Poliwczak: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
This PR (HEAD: 370428e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from mzh: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
This PR (HEAD: 6cd89de) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 7: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 7: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Mateusz Poliwczak: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Mateusz Poliwczak: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Mateusz Poliwczak: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
This PR (HEAD: ac2d24d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Fixes: golang#44741, adds explicit error if domain not found in /etc/hosts while using hostLookupFiles mode
ac2d24d
to
f88ed38
Compare
This PR (HEAD: 41614f1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Meng Zhuo: Patch Set 9: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 9: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
This PR (HEAD: 3d47e44) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/382996 to see it. Tip: You can toggle comments from me using the |
Message from Mateusz Poliwczak: Patch Set 9: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Ian Lance Taylor: Patch Set 10: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
Message from Gopher Robot: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/382996. |
It adds support for /etc/hosts aliases and fixes the difference between the glibc cgo and the go DNS resolver. Examples: https://pastebin.com/Fv6UcAVr Fixes #44741 Change-Id: I98c484fced900731fbad800278b296028a45f044 GitHub-Last-Rev: 3d47e44 GitHub-Pull-Request: #51004 Reviewed-on: https://go-review.googlesource.com/c/go/+/382996 Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Damien Neil <dneil@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/382996 has been merged. |
It adds support for /etc/hosts aliases and fixes the difference between the glibc cgo and the go DNS resolver.
Examples: https://pastebin.com/Fv6UcAVr
Fixes #44741