Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: consider to suppress diagnostics on code in GOMODCACHE #52106

Open
hyangah opened this issue Apr 1, 2022 · 0 comments
Open

x/tools/gopls: consider to suppress diagnostics on code in GOMODCACHE #52106

hyangah opened this issue Apr 1, 2022 · 0 comments
Labels
FeatureRequest gopls Tools
Milestone

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Apr 1, 2022

Spin-off from #51947 (comment)

Gopls is not suppressing diagnostics because GOMODCACHE is under the repo root, even though it is not included in the workspace. We should fix this.

That will help handling golang/vscode-go#2080 and golang/vscode-go#170 too - which may end up encouraging users to add the source code of the dependencies to the workspace.

@hyangah hyangah added FeatureRequest gopls labels Apr 1, 2022
@gopherbot gopherbot added the Tools label Apr 1, 2022
@gopherbot gopherbot added this to the Unreleased milestone Apr 1, 2022
@suzmue suzmue removed this from the Unreleased milestone Apr 4, 2022
@suzmue suzmue added this to the gopls/on-deck milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest gopls Tools
Projects
None yet
Development

No branches or pull requests

3 participants