New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: cgoLookupIPCNAME doesn't try again for temporary failures in getaddrinfo() #5338

Open
anacrolix opened this Issue Apr 23, 2013 · 9 comments

Comments

Projects
None yet
3 participants
@anacrolix
Contributor

anacrolix commented Apr 23, 2013

go version devel +55f0ec9b3c00 Mon Apr 22 22:09:11 2013 -0700 linux/amd64

Heavy usage of net.Dial via net/http.Get gives errors stringifying as " Temporary
failure in name resolution" which corresponds to EAI_AGAIN returned from
getaddrinfo().

I expect net.Dial to retry on this error code.

I'm using 6g on Linux.

No effort is made to set the IsTimeout member of DNSError at the callsite
http://code.google.com/p/go/source/browse/src/pkg/net/cgo_unix.go#98, and an appropriate
IsTemporary variable is not available.
@rsc

This comment has been minimized.

Contributor

rsc commented Jul 30, 2013

Comment 2:

When should it try again? I'm kind of confused.

Labels changed: added priority-later, go1.2maybe, removed priority-triage.

Status changed to Accepted.

@rsc

This comment has been minimized.

Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added feature.

@anacrolix

This comment has been minimized.

Contributor

anacrolix commented Jul 31, 2013

Comment 4:

When calling getaddrinfo, EAI_AGAIN should be retried in synchronous calling code no?
@robpike

This comment has been minimized.

Contributor

robpike commented Aug 20, 2013

Comment 5:

Deferring to 1.3.

Labels changed: added go1.3maybe, removed go1.2maybe.

@robpike

This comment has been minimized.

Contributor

robpike commented Aug 20, 2013

Comment 6:

Labels changed: removed go1.3maybe.

@rsc

This comment has been minimized.

Contributor

rsc commented Nov 27, 2013

Comment 7:

Labels changed: added go1.3maybe.

@rsc

This comment has been minimized.

Contributor

rsc commented Nov 27, 2013

Comment 8:

Labels changed: removed feature.

@rsc

This comment has been minimized.

Contributor

rsc commented Dec 4, 2013

Comment 9:

Labels changed: added release-none, removed go1.3maybe.

@rsc

This comment has been minimized.

Contributor

rsc commented Dec 4, 2013

Comment 10:

Labels changed: added repo-main.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment