Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/goexperiment: remove CoverageRedesign some time in 1.23 #55953

Open
thanm opened this issue Sep 29, 2022 · 8 comments
Open

internal/goexperiment: remove CoverageRedesign some time in 1.23 #55953

thanm opened this issue Sep 29, 2022 · 8 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@thanm
Copy link
Contributor

thanm commented Sep 29, 2022

This is a tracking issue to remove the "CoverageRedesign" GOEXPERIMENT some time in the Go 1.21 release; at that point hopefully any remaining (potential) bugs/issues with the new coverage design will be ironed out, and we will no longer need the GOEXPERIMENT=nocoverageredesign fallback.

@thanm

@thanm thanm added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 29, 2022
@thanm thanm added this to the Go1.21 milestone Sep 29, 2022
@thanm thanm self-assigned this Sep 29, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Sep 29, 2022
@thanm thanm modified the milestones: Go1.21, Go1.22 Jun 27, 2023
@AlekSi
Copy link
Contributor

AlekSi commented Aug 17, 2023

I guess the title should be updated too

@thanm thanm changed the title internal/goexperiment: remove CoverageRedesign some time in 1.21 internal/goexperiment: remove CoverageRedesign some time in 1.22 Aug 17, 2023
@thanm
Copy link
Contributor Author

thanm commented Aug 17, 2023

Thanks. Updated.

@thanm
Copy link
Contributor Author

thanm commented Aug 17, 2023

Removing the experiment didn't make the 1.21 release, there are still some bugfix CLs not yet submitted (e.g. 495446, 495447, and 495452). Once those go in I should be in a better position to get rid of the experiment.

@tombrown52
Copy link

@thanm Is this likely to be removed in 1.22, or bumped to 1.23? (I tried to find links to the issues you included, 495446, 495447, and 495452, but was unsuccessful)

@thanm
Copy link
Contributor Author

thanm commented Oct 31, 2023

Hi @tombrown52,

Thanks for the note. That last comment I posted was a bit cryptic, sorry about that. "495446, 495447, and 495452" are Gerrit CLs, not issues. These CLs have now been merged, and bugs they were intended to address have been closed. More details with links:

CLs 495446 and 495447 are for issues #18909 and #24570.

CL 495452 is for issue #58770.

My intent was to have these fixed early in this cycle, but for a variety of reasons this didn't happen. As a result we're going to bump the deletion of GOEXPERIMENT=coverageredesign until the next release; with less than a month to go before the freeze, it is better to wait until early in the next cycle.

@tombrown52
Copy link

@thanm Thanks for the update!

@thanm
Copy link
Contributor Author

thanm commented Nov 22, 2023

Bumping milestone to 1.23

@thanm thanm changed the title internal/goexperiment: remove CoverageRedesign some time in 1.22 internal/goexperiment: remove CoverageRedesign some time in 1.23 Nov 22, 2023
@Feggah
Copy link

Feggah commented Feb 21, 2024

I have generated packages in my monorepo that I don't want to include in the coverage report. With GOEXPERIMENT=nocoverageredesign they are not included.

If this is removed, how can I remove specific packages from the coverage? For example, I would like to ignore all packages within the paths:

  • sdk/generated/**
  • **/mocks/*

Is it possible to do that configuration in the go test command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Development

No branches or pull requests

5 participants