Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite-metrics: build failures on aix and solaris since CL 464635 #58301

Closed
bcmills opened this issue Feb 3, 2023 · 2 comments
Closed

x/pkgsite-metrics: build failures on aix and solaris since CL 464635 #58301

bcmills opened this issue Feb 3, 2023 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-AIX OS-Solaris
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 3, 2023

CL 464635 (attn @julieqiu, @jba) added a dependency on github.com/go-git/go-billy, which seems to rely on the not-quite-portable flock system call. It fails to build on both the aix and the solaris builders:

https://build.golang.org/log/16e55aaaf5cd0530197e39196e8b5574ce26d1d5

aix-ppc64 at fcd0e0963f3bdf289216c1083f1439a71dc571a4 building pkgsite-metrics at 4260eec4c420289d41ba5777be826919d16b4408
…
# github.com/go-git/go-billy/v5/osfs
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:15:14: undefined: unix.Flock
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:22:14: undefined: unix.Flock
?   	golang.org/x/pkgsite-metrics/cmd/worker	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/derrors	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/observe	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/proxy/proxytest	[no test files]
?   	golang.org/x/pkgsite-metrics/internal/testing/testhelper	[no test files]
go version devel fcd0e0963f3bdf289216c1083f1439a71dc571a4 aix/ppc64
Checking go and sh files for license header
go vet -all ./...

# github.com/go-git/go-billy/v5/osfs
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:15:14: undefined: unix.Flock
../../../../pkg/mod/github.com/go-git/go-billy/v5@v5.4.0/osfs/os_posix.go:22:14: undefined: unix.Flock
command failed
Installing: github.com/client9/misspell/cmd/misspell
⋯
FAILED; see errors above
--- FAIL: Test (41.70s)
    all_test.go:26: exit status 1
FAIL
FAIL	golang.org/x/pkgsite-metrics	41.754s

https://build.golang.org/log/1cef20b2732f80f0dc5839208b565552e0c9d0ab

solaris-amd64-oraclerel at 01a5a83cfbe594538f6fe9f49bd27d9dc36155a4 building pkgsite-metrics at 4260eec4c420289d41ba5777be826919d16b4408
…
# golang.org/x/pkgsite-metrics/internal/stdlib.test
/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/pkg/tool/solaris_amd64/link: running gcc failed: exit status 1
Undefined			first referenced
 symbol  			    in file
flock                               /opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/go-link-1706862252/go.o
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
…
FAIL	golang.org/x/pkgsite-metrics/internal/stdlib [build failed]
@gopherbot gopherbot added this to the Unreleased milestone Feb 3, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Feb 3, 2023

This can be addressed by either fixing the build on those platforms or, if x/pkgsite-metrics intentionally does not support them, by configuring cmd/coordinator not to test that repo on them.

@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. OS-AIX OS-Solaris labels Feb 3, 2023
@julieqiu
Copy link
Member

julieqiu commented Feb 8, 2023

@julieqiu julieqiu closed this as completed Feb 8, 2023
@golang golang locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-AIX OS-Solaris
Projects
None yet
Development

No branches or pull requests

3 participants