Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: enable snapshotting for misc-compile builders #58310

Open
mknyszek opened this issue Feb 3, 2023 · 2 comments
Open

x/build: enable snapshotting for misc-compile builders #58310

mknyszek opened this issue Feb 3, 2023 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. ToolSpeed
Milestone
Unreleased

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Feb 3, 2023

Right now misc-compile builders don't snapshot at all, forcing a re-run of make.bash. This is especially annoying for subrepos, since it adds a bunch of unnecessary build latency. We should at the very least enable snapshotting per builder name (which makes sense, since we'll have std built for the given GOOS/GOARCH).
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 3, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 3, 2023
@mknyszek
Copy link
Contributor Author

mknyszek commented Feb 3, 2023

CC @golang/release

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 3, 2023
@bcmills
Copy link
Contributor

bcmills commented Feb 6, 2023

Since the Go compiler is a cross-compiler on every platform, we could alternately run all of the misc-compile subrepo builders with a common, already-snapshotted host toolchain (such as linux/amd64).

The x/build changes might be more invasive, but the end result would be more resource-efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. ToolSpeed
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @bcmills @gopherbot