Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: advertise correct ciphers [freeze exception] #60423

Closed
rolandshoemaker opened this issue May 25, 2023 · 1 comment
Closed

crypto/tls: advertise correct ciphers [freeze exception] #60423

rolandshoemaker opened this issue May 25, 2023 · 1 comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Go1.21

Comments

@rolandshoemaker
Copy link
Member

A CL for #57771 (http://go.dev/cl/360794) was sent and reviewed before the freeze, but since it didn't appear in the go.dev/s/needs-review dashboard it slipped and wasn't +1'd until after the freeze. The change is small, tested, reviewed, and fixes a TLS specification non-conformance issue. As such I don't believe it is high risk, and is reasonable to merge during the freeze.

cc @golang/release
@rolandshoemaker rolandshoemaker added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label May 25, 2023
@dmitshur dmitshur added this to the Go1.21 milestone May 25, 2023
@rolandshoemaker
Copy link
Member Author

This is a bug fix, which is still allowed, ignore me, low blood sugar 🤦.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
Go Release
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@dmitshur @rolandshoemaker