-
Notifications
You must be signed in to change notification settings - Fork 17.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/fix: invalid -go=go1.21.0 #62584
Labels
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
This was referenced Sep 12, 2023
so should I update my go version to 1.21 or newer? |
ok so the workarond is to edit the |
@heschi what do we need to do to merge linked PR? Thanks! |
The aforementioned PR is https://go.dev/cl/527342. Not sure why it didn't cross-reference here. 🤔 |
Change https://go.dev/cl/527342 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
NeedsFix
The path to resolution is known, but the work has not been done.
According to my understanding of these docs:
https://go.dev/doc/go1.21#tools
https://go.dev/doc/toolchain#version
https://go.dev/ref/mod#go-mod-file-go
before go 1.21 it was not allowed to specify the patch version in the
go.mod
.so the code in fix cmd:
go/src/cmd/fix/main.go
Lines 78 to 79 in 905b58b
does not handle string
1.21.0
.Existing code also won't work with
go 1.21rc1
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
Expected go fix to remove the deprecated build tag.
What did you see instead?
Error about invalid version.
The text was updated successfully, but these errors were encountered: