Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/pprof: don't rely on either just LWP::UserAgent or just curl #6273

Closed
cldorian opened this issue Aug 28, 2013 · 6 comments
Closed

misc/pprof: don't rely on either just LWP::UserAgent or just curl #6273

cldorian opened this issue Aug 28, 2013 · 6 comments

Comments

@cldorian
Copy link
Contributor

Since CL 13085043, pprof is broken on OS X Version 10.8.4.

What steps will reproduce the problem?
go tool pprof

What is the expected output?


What do you see instead?

Can't locate LWP/UserAgent.pm in @INC (@INC contains:
/opt/local/lib/perl5/site_perl/5.12.4/darwin-thread-multi-2level
/opt/local/lib/perl5/site_perl/5.12.4
/opt/local/lib/perl5/vendor_perl/5.12.4/darwin-thread-multi-2level
/opt/local/lib/perl5/vendor_perl/5.12.4
/opt/local/lib/perl5/5.12.4/darwin-thread-multi-2level /opt/local/lib/perl5/5.12.4
/opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl .) at
/Users/charles/go/pkg/tool/darwin_amd64/pprof line 82.
BEGIN failed--compilation aborted at /Users/charles/go/pkg/tool/darwin_amd64/pprof line
82.

Which compiler are you using (5g, 6g, 8g, gccgo)?
6g (but N/A)

Which operating system are you using?
OS x Version 10.8.4

Which version are you using?  (run 'go version')
go version devel +0ff127f41a08 Wed Aug 28 14:43:56 2013 +1000 darwin/amd64

Please provide any additional information below.
mb:~ charles$ perl -v
This is perl 5, version 12, subversion 4 (v5.12.4) built for darwin-thread-multi-2level

UserAgent.pm found in /opt/local/lib/perl5/5.12.4/CPAN/LWP/
@bradfitz
Copy link
Contributor

Comment 1:

Sigh.  I was going to complain about this too on the earlier CL which I approved, since
I knew LWP::UserAgent wasn't part of the Perl standard library, but on every machine I
could find, it was installed, so I figured all distros (including Macs) just installed
it anyway these days.
But at home I have a Mac without it, so I guess not.
Will fix.

Owner changed to @bradfitz.

Status changed to Accepted.

@dvyukov
Copy link
Member

dvyukov commented Aug 29, 2013

Comment 3:

Is not it easier to rewrite pprof in Go?

@bradfitz
Copy link
Contributor

Comment 4:

Easier or less time consuming? And for whom?
I don't have time to rewrite it in Go.
Here's the perl fix:  https://golang.org/cl/13330044/

Status changed to Started.

@dvyukov
Copy link
Member

dvyukov commented Aug 29, 2013

Comment 5:

I meant:
- easier to maintain, more consistent with the rest of Go toolchain
- better for users (on windows you do not have perl by default)

@bradfitz
Copy link
Contributor

Comment 6:

I 100% agree. I filed issue #6281 for that.  I'm not doing it now.

@bradfitz
Copy link
Contributor

Comment 7:

This issue was closed by revision ccfe1bf.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants