Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.ServeContent reads too much before calling DetectContentType #6311

Closed
tbushnell opened this issue Sep 3, 2013 · 2 comments
Closed

http.ServeContent reads too much before calling DetectContentType #6311

tbushnell opened this issue Sep 3, 2013 · 2 comments

Comments

@tbushnell
Copy link

The documented interface for http.DetectContentType says that it only uses 512 bytes of
data to make its decision, and the code seems to agree with that comment.

But http.ServeContent (serveContent, really) reads twice that much. It should only read
the amount that DetectContentType is using.
@bradfitz
Copy link
Contributor

bradfitz commented Sep 3, 2013

Comment 1:

https://golang.org/cl/13289047

Owner changed to @bradfitz.

Status changed to Started.

@bradfitz
Copy link
Contributor

bradfitz commented Sep 3, 2013

Comment 2:

This issue was closed by revision 8272c14.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants