internal/msan: add new package #64637

mauri870 · 2023-12-10T16:07:06Z

The internal/msan package contains helper functions for manually
instrumenting code for the memory sanitizer. It exports the private
msan routines in runtime unconditionally, making the functions a
no-op if the build flag "msan" is not present.

For #64611

gopherbot · 2023-12-10T16:16:13Z

This PR (HEAD: e64fa83) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

The internal/msan package contains helper functions for manually instrumenting code for the memory sanitizer. It exports the private msan routines in runtime uncoditionally, making the functions a no-op if the build flag "msan" is not present. For golang#64611

gopherbot · 2023-12-10T16:28:54Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-10T16:29:00Z

This PR (HEAD: c32930f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-10T23:55:55Z

This PR (HEAD: ac00e16) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-29T19:42:18Z

Message from Austin Clements:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T20:07:11Z

Message from Cherry Mui:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T20:07:11Z

Message from Cherry Mui:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T20:07:12Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-29T19:58:49Z","revision":"2ef835f4d099b0e331094577502c752b362ae797"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T20:13:53Z

Message from Cherry Mui:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T20:13:54Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):

FAILURE

go on master (change 548676)

Tests failed. See all test results.

Error:
shard 1: failed to run "go tool dist test -json": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T20:13:55Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

Change-Id: Ia17d43fa26189110ebba32388e2bbb5aede430a1

gopherbot · 2024-01-29T21:21:11Z

This PR (HEAD: 84da740) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-29T21:27:12Z

Message from Mauri de Souza Meneguzzo:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

Change-Id: I4a88d49272569a8fb9d1e9779ff390ba01f20e87

gopherbot · 2024-02-07T22:31:29Z

This PR (HEAD: 8d57d84) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-07T22:51:13Z

This PR (HEAD: dcb3651) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-07T23:16:43Z

Message from Mauri de Souza Meneguzzo:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T11:15:46Z

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T21:59:26Z

Message from Bryan Mills:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T21:59:27Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-08T21:52:20Z","revision":"c979bbca1e184f292465a59aaf1aac9463724ce2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T21:59:27Z

Message from Cherry Mui:

Patch Set 6: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T22:17:49Z

Message from Bryan Mills:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T22:17:49Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-08T22:17:50Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T11:53:21Z

This PR (HEAD: 517d50d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-09T11:59:28Z

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T23:24:16Z

This PR (HEAD: 0a644bd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/548676.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-16T23:36:09Z

Message from Mauri de Souza Meneguzzo:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T23:42:04Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-16T23:26:58Z","revision":"c3d74525a55cabf688bcc1fc4be8db587e3fe185"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T23:53:39Z

Message from Mauri de Souza Meneguzzo:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T23:53:39Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T23:53:40Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-16T23:53:40Z

Message from Mauri de Souza Meneguzzo:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/548676.
After addressing review feedback, remember to publish your drafts!

The internal/msan package contains helper functions for manually instrumenting code for the memory sanitizer. It exports the private msan routines in runtime unconditionally, making the functions a no-op if the build flag "msan" is not present. For #64611 Change-Id: If43f29e112ac79a47083c9dbdf2c61a0641e80b1 GitHub-Last-Rev: 0a644bd GitHub-Pull-Request: #64637 Reviewed-on: https://go-review.googlesource.com/c/go/+/548676 Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-02-20T20:58:29Z

This PR is being closed because golang.org/cl/548676 has been merged.

mauri870 force-pushed the feature/internal-msan branch 2 times, most recently from 8896a09 to e64fa83 Compare December 10, 2023 16:09

mauri870 force-pushed the feature/internal-msan branch from e64fa83 to c32930f Compare December 10, 2023 16:27

use runtime functions directly

ac00e16

mauri870 added 2 commits January 29, 2024 18:13

Merge branch 'master' into feature/internal-msan

d533680

Change-Id: Ia17d43fa26189110ebba32388e2bbb5aede430a1

add linkname to runtime funcs, fix package docs

84da740

Merge branch 'master' into feature/internal-msan

8d57d84

Change-Id: I4a88d49272569a8fb9d1e9779ff390ba01f20e87

fix TestDependencies

dcb3651

fix header year

517d50d

Merge branch 'master' into feature/internal-msan

0a644bd

gopherbot closed this Feb 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/msan: add new package #64637

internal/msan: add new package #64637

mauri870 commented Dec 10, 2023 •

edited

gopherbot commented Dec 10, 2023

gopherbot commented Dec 10, 2023

gopherbot commented Dec 10, 2023

gopherbot commented Dec 10, 2023

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 20, 2024

internal/msan: add new package #64637

internal/msan: add new package #64637

Conversation

mauri870 commented Dec 10, 2023 • edited

gopherbot commented Dec 10, 2023

gopherbot commented Dec 10, 2023

gopherbot commented Dec 10, 2023

gopherbot commented Dec 10, 2023

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 7, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 8, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 9, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 16, 2024

gopherbot commented Feb 20, 2024

mauri870 commented Dec 10, 2023 •

edited