Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: compute references/refactoring for all build configurations #64887

Open
findleyr opened this issue Dec 28, 2023 · 0 comments
Open
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

This issue follows up on zero-config gopls (#57979). With that change, gopls can dynamically add build configurations (Views) to work on, as files are opened and closed.

But for performance reasons, gopls does not load all build configurations: go list can take upwards of 10s, and there are ~50 supported ports.

However, when performing a workspace-wide refactoring such as renaming, or even while finding references, we should consider analyzing all workspace files to compute the set of required build configurations, and applying the refactoring for these configurations, since this is likely a much smaller set.

CC @adonovan @suzmue

@findleyr findleyr added this to the gopls/v0.16.0 milestone Dec 28, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants