Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/trace/v2: TestTraceStressStartStop/Default failures #65318

Closed
gopherbot opened this issue Jan 26, 2024 · 4 comments
Closed

internal/trace/v2: TestTraceStressStartStop/Default failures #65318

gopherbot opened this issue Jan 26, 2024 · 4 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
default <- pkg == "internal/trace/v2" && test == "TestTraceStressStartStop/Default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestTraceStressStartStop/Default
    reader_test.go:112: unexpected error while reading the trace: broken trace: failed to advance: frontier:
        [gen=5]
        
        M 1098478 [ProcStart time=61707444740480 p=3 p_seq=15]
        
        G 12 [status=Waiting seq=0 (gen=5)]
        G 13 [status=Waiting seq=0 (gen=5)]
        G 11 [status=Waiting seq=0 (gen=5)]
        G 43 [status=Waiting seq=1 (gen=5)]
...
        String id=129
        	data="net.(*conn).Write"
        String id=130
        	data="sync.(*WaitGroup).Wait"
        String id=131
        	data="runtime.block"
        String id=132
        	data="/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/select.go"
        
--- FAIL: TestTraceStressStartStop/Default (0.89s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 26, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "internal/trace/v2" && test == "TestTraceStressStartStop/Default"
2024-01-26 17:53 gotip-linux-386-longtest go@8081c084 internal/trace/v2.TestTraceStressStartStop/Default (log)
=== RUN   TestTraceStressStartStop/Default
    reader_test.go:112: unexpected error while reading the trace: broken trace: failed to advance: frontier:
        [gen=5]
        
        M 1098478 [ProcStart time=61707444740480 p=3 p_seq=15]
        
        G 12 [status=Waiting seq=0 (gen=5)]
        G 13 [status=Waiting seq=0 (gen=5)]
        G 11 [status=Waiting seq=0 (gen=5)]
        G 43 [status=Waiting seq=1 (gen=5)]
...
        String id=129
        	data="net.(*conn).Write"
        String id=130
        	data="sync.(*WaitGroup).Wait"
        String id=131
        	data="runtime.block"
        String id=132
        	data="/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/select.go"
        
--- FAIL: TestTraceStressStartStop/Default (0.89s)

watchflakes

@bcmills bcmills added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 29, 2024
@bcmills
Copy link
Contributor

bcmills commented Jan 29, 2024

(Note that linux/386 is currently a first class port.)

@mknyszek mknyszek added this to the Backlog milestone Jan 31, 2024
@mknyszek mknyszek self-assigned this Jan 31, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2024

I see the problem here. P states aren't always correctly cleaned up for future generations when the trace stops. I'll send a CL for this.

@gopherbot
Copy link
Author

Change https://go.dev/cl/567077 mentions this issue: runtime: clean up dead P trace state when disabling tracing too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Done
Development

No branches or pull requests

3 participants