Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Client.Do blocks on DNS AAAA record until timeout even after A record succeeds [1.22 backport] #66050

Closed
gopherbot opened this issue Mar 1, 2024 · 4 comments
Milestone

Comments

@gopherbot
Copy link

@kkHAIKE requested issue #57697 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 1, 2024
@gopherbot gopherbot added this to the Go1.22.1 milestone Mar 1, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/565296 mentions this issue: [release-branch.go1.22] net: prevent unintended retries upon receiving an empty answer response from the DNS server.

@gopherbot gopherbot modified the milestones: Go1.22.1, Go1.22.2 Mar 5, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Mar 6, 2024

We're leaning toward denying this issue for backport because it's an old bug (since at least Go 1.18) and the risk of introducing a new bug in an old release is too high.

Do you have any additional justification for backporting this issue? Also, backports (per our policy) always need to apply to both supported Go releases (so in this case Go 1.21 and Go 1.22) if it applies to both.

@kkHAIKE
Copy link
Contributor

kkHAIKE commented Mar 10, 2024

Actually, I also want to backport to 1.21, but this CL depends on https://go-review.googlesource.com/c/go/+/514835, and it's not a bug fix CL, so I'm quite troubled.

@thanm
Copy link
Contributor

thanm commented Mar 27, 2024

Discussed in the go release team weekly checkin. Given no new information we've decided to reject this backport request, thanks.

@thanm thanm removed the CherryPickCandidate Used during the release process for point releases label Mar 27, 2024
@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants