Skip to content

x/pkgsite: broken source file links for modules without hosted sources #66432

@seankhliao

Description

@seankhliao

What is the URL of the page with the issue?

https://pkg.go.dev/buf.build/gen/go/grpc/grpc/protocolbuffers/go/grpc/service_config

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36

Screenshot

No response

What did you do?

This is an example of a module with its canonical source being a module host (proxy?)

https://pkg.go.dev/buf.build/gen/go/grpc/grpc/protocolbuffers/go/grpc/service_config

We can see it doesn't define source meta tags with:

$ curl 'https://buf.build/gen/go/grpc/grpc/protocolbuffers/go?go-get=1' 

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
	<meta name="go-import" content="buf.build/gen/go/grpc/grpc/protocolbuffers/go mod https://buf.build/gen/go">
	<title>Buf | Module buf.build/gen/go/grpc/grpc/protocolbuffers/go</title>
</head>

In the "Source Files" section on the page, the links to the filenames are clickable but they are just a self link to the current page.

What did you see happen?

Link to current page, confused by a page refresh and no source shown.

What did you expect to see?

The source files should not be clickable.

Or something like https://go-mod-viewer.appspot.com/ is used to show the source files (not sure who owns this but I saw @adonovan use it0

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions