Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite/internal/middleware: TestCache failures #66548

Open
gopherbot opened this issue Mar 27, 2024 · 2 comments
Open

x/pkgsite/internal/middleware: TestCache failures #66548

gopherbot opened this issue Mar 27, 2024 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/middleware" && test == "TestCache"

Issue created automatically to collect these failures.

Example (log):

2024/03/26 15:37:41 Info: caching response of length 25 for /A
2024/03/26 15:37:42 Info: cache get("/A"): context timed out
2024/03/26 15:37:42 Info: caching response of length 25 for /A
2024/03/26 15:37:42 Debug: serving "/A" from cache
--- FAIL: TestCache (0.21s)
    caching_test.go:156: [A is cached] GET returned status 403, want 200
    caching_test.go:164: [A is cached] GET returned body 3, want 2
    caching_test.go:182: [A is cached] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 2,
...
        + 	true:  1,
          }
    caching_test.go:182: [bypassing the cache] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
2024/03/26 15:37:42 Error: middleware.Panic: panic!

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 27, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 27, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/middleware" && test == "TestCache"
2024-03-05 19:44 darwin-amd64-12_0 pkgsite@ea431292 go@b47f2feb x/pkgsite/internal/middleware.TestCache (log)
2024/03/26 15:37:41 Info: caching response of length 25 for /A
2024/03/26 15:37:42 Info: cache get("/A"): context timed out
2024/03/26 15:37:42 Info: caching response of length 25 for /A
2024/03/26 15:37:42 Debug: serving "/A" from cache
--- FAIL: TestCache (0.21s)
    caching_test.go:156: [A is cached] GET returned status 403, want 200
    caching_test.go:164: [A is cached] GET returned body 3, want 2
    caching_test.go:182: [A is cached] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 2,
...
        + 	true:  1,
          }
    caching_test.go:182: [bypassing the cache] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
2024/03/26 15:37:42 Error: middleware.Panic: panic!

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/middleware" && test == "TestCache"
2024-04-16 22:18 darwin-amd64-nocgo pkgsite@6631f544 go@a0205e65 x/pkgsite/internal/middleware.TestCache (log)
2024/04/18 22:26:52 Info: caching response of length 25 for /A
2024/04/18 22:26:52 Debug: serving "/A" from cache
2024/04/18 22:26:52 Info: caching response of length 25 for /A
2024/04/18 22:26:52 Info: cache get("/A"): context timed out
2024/04/18 22:26:52 Info: caching response of length 25 for /A
--- FAIL: TestCache (0.22s)
    caching_test.go:164: [A is cached again] GET returned body 5, want 4
    caching_test.go:182: [A is cached again] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
    caching_test.go:182: [bypassing the cache] CacheResultCount diff (-want +got):
          map[bool]int{
        - 	false: 3,
        + 	false: 4,
        - 	true:  2,
        + 	true:  1,
          }
2024/04/18 22:26:52 Error: context deadline exceeded
2024/04/18 22:26:52 Error: context deadline exceeded
2024/04/18 22:26:52 Error: context deadline exceeded
2024/04/18 22:26:52 Error: context deadline exceeded
2024/04/18 22:26:52 Error: context deadline exceeded
2024/04/18 22:26:52 Error: context deadline exceeded
2024/04/18 22:26:52 Error: context canceled
2024/04/18 22:26:53 Error: middleware.Panic: panic!

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

1 participant