-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite/cmd/pkgsite: Use relative links for static
, etc.
#66858
Comments
where is this visual studio code feature documented? |
static
should use.static
, etc.
@seankhliao I updated the title and description a bit. It looks like this specific issue is directly related to using It looks like this https://coder.com/docs/code-server/latest/guide#stripping-proxyport-from-the-request-path Stripping
|
sounds like you should just use |
No, that makes no difference. I am pretty sure that only prevents I think the issue here is that This path won't work since it is really at |
cc/ @jmcshane |
static
, etc.static
, etc.
CC @matloob |
cc @jba I don't know what the implications are for pkg.go.dev if we do such a change. It seems like there might be many places where we'd need to update the paths. |
What is the URL of the page with the issue?
N/A
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
Screenshot
What did you do?
When running
pkgsite -open .
locally in a remote Visual Studio Code terminal (via code-server), a proxy will be started.https://coder.com/docs/code-server/latest/guide#stripping-proxyport-from-the-request-path
This typically means that the main page will be at https://${hostname}/proxy/8080/ and the
static
directories will be under the path/proxy/8080/static/
. However, it appears that the site always tries to find them under/static
, and there is no obvious way to change this.What did you see happen?
None of the static CSS or images will load.
What did you expect to see?
All of the static CSS and images load.
The text was updated successfully, but these errors were encountered: