Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/arch: add RISC-V support for disassembler #66939

Open
lrzlin opened this issue Apr 20, 2024 · 3 comments
Open

x/arch: add RISC-V support for disassembler #66939

lrzlin opened this issue Apr 20, 2024 · 3 comments
Labels
arch-riscv Issues solely affecting the riscv64 architecture. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unreleased

Comments

@lrzlin
Copy link

lrzlin commented Apr 20, 2024 •
edited

The go debugger go-delve use the go/arch package as the disassembler, add RISC-V support to it enables further development for golang/riscv's ecosystem.

I have submit a patch on https://go-review.googlesource.com/c/arch/+/493935, does it still needs any improvement? or I should divide them into seperate patches due to it's size?
@gopherbot gopherbot added this to the Proposal milestone Apr 20, 2024
@seankhliao seankhliao added the arch-riscv Issues solely affecting the riscv64 architecture. label Apr 20, 2024
@seankhliao
Copy link
Member

cc @golang/riscv64

@seankhliao seankhliao changed the title proposal: x/arch: Add RISC-V support for disassembler proposal: x/arch: add RISC-V support for disassembler Apr 20, 2024
@ianlancetaylor
Copy link
Contributor

I don't think this needs to be a proposal.

@ianlancetaylor ianlancetaylor changed the title proposal: x/arch: add RISC-V support for disassembler x/arch: add RISC-V support for disassembler Apr 21, 2024
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Unreleased Apr 21, 2024
@lrzlin
Copy link
Author

lrzlin commented Apr 21, 2024

I don't think this needs to be a proposal.

Thank you for amend it, I'm not familiar with the issue category rules.

@joedian joedian added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-riscv Issues solely affecting the riscv64 architecture. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@ianlancetaylor @gopherbot @seankhliao @joedian @lrzlin