Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestSendfile does not use sendfile on Windows #67042

Open
neild opened this issue Apr 25, 2024 · 0 comments
Open

net: TestSendfile does not use sendfile on Windows #67042

neild opened this issue Apr 25, 2024 · 0 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.

Comments

@neild
Copy link
Contributor

neild commented Apr 25, 2024

https://go.dev/cl/581778 extends the existing TestSendfile* tests in the net package to check to see if sendfile (or the platform equivalent) is actually used.

It appears that in the case of TestSendfile on Windows, we aren't using TransmitFile. Other tests, such as TestSendfileParts are using TransmitFile. I'm not sure what's going wrong. I'll make the test skip the check on Windows for now; filing a bug to keep track of the problem.
@joedian joedian added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neild @joedian