Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add LUCI illumos-amd64 builder #67302

Open
dmitshur opened this issue May 10, 2024 · 4 comments
Open

x/build: add LUCI illumos-amd64 builder #67302

dmitshur opened this issue May 10, 2024 · 4 comments
Assignees
Labels
arch-amd64 Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-illumos
Milestone

Comments

@dmitshur
Copy link
Contributor

There currently isn't a LUCI builder that tests the illumos/amd64 port (other than the misc-compile builder, which tests only that the port compiles). This is the tracking issue for it.

The next steps that a builder owner will need to follow to make progress here are documented https://go.dev/wiki/DashboardBuilders#luci-builders.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-illumos arch-amd64 labels May 10, 2024
@dmitshur dmitshur added this to the Unreleased milestone May 10, 2024
@jclulow jclulow self-assigned this May 10, 2024
@jclulow
Copy link
Contributor

jclulow commented May 16, 2024

G'day! I am creating the new builder with hostname illumos-amd64-jclulow.

The CSR is attached: illumos-amd64-jclulow.csr.txt

Please, Mr. Music, will you play?

@dmitshur dmitshur self-assigned this May 16, 2024
@dmitshur
Copy link
Contributor Author

dmitshur commented May 16, 2024

Thank you for starting to work on this builder. Here's the certificate:
illumos-amd64-jclulow-1715889249.cert.txt.

Edit: I'll also note that if the previous coordinator-based builder starts to get in the way of you bringing up the new LUCI builder, you should feel free to stop the previous builder and focus on the new one. It's certainly fine to keep the old one running if it doesn't get in the way. Thanks.

@dmitshur dmitshur removed their assignment May 16, 2024
@jclulow
Copy link
Contributor

jclulow commented May 17, 2024

I put the new one in a new VM, so they don't interact. The host is definitely getting LUCI tokens, and the swarm thing is definitely doing something inscrutable and then rebooting the instance every now and again.

I had a peek in some logs, and I think it's a bit confused about the platform: it says "solaris-amd64" in a bunch of log messages, which is obviously not quite right, it should be "illumos-amd64" presumably.

Please let me know what to do next!

@dmitshur
Copy link
Contributor Author

dmitshur commented May 17, 2024

Thanks for getting to this point.

The bot is visible at https://chromium-swarm.appspot.com/bot?id=illumos-amd64-jclulow. As you noted, it's identifying itself as having a cipd_platform value of "solaris-amd64", but we indeed need it to be "illumos-amd64" in order to match the builder definition at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-illumos-amd64.

I suggest stopping this builder for now to avoid it providing noise for the https://ci.chromium.org/ui/p/golang/builders/ci/gotip-solaris-amd64 builder.

The next steps here will be to make a change in the swarming bot code to report its OS as illumos rather than solaris. The relevant code is here:

https://source.chromium.org/chromium/infra/infra/+/main:luci/appengine/swarming/swarming_bot/api/os_utilities.py;l=291-301;drc=4b5b630058c9a41d6ddcb7cef61630b434eeccb0

I suggest taking a look at a previous example of a similar change being done in #64660 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-amd64 Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder OS-illumos
Projects
Status: In Progress
Development

No branches or pull requests

2 participants