Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make.bash build failure with "cannot use debug.SetCrashOutput" #67404

Closed
gopherbot opened this issue May 15, 2024 · 4 comments
Closed
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented May 15, 2024

#!watchflakes
post <- mode == "build" && log ~ `x\/telemetry\/internal\/crashmonitor\/crash_go123\.go:13:19: cannot use debug\.SetCrashOutput \(value of type func\(f \*os\.File, opts \.\.\.debug\.CrashOptions\) error\) as func\(\*os\.File\) error value in assignment`

Issue created automatically to collect these failures.

Example (log):

Building Go cmd/dist using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap. (go1.20.6 darwin/amd64)
Building Go toolchain1 using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
# cmd/vendor/golang.org/x/telemetry/internal/crashmonitor
../../w/goroot/src/cmd/vendor/golang.org/x/telemetry/internal/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts ...debug.CrashOptions) error) as func(*os.File) error value in assignment
go tool dist: FAILED: /Users/swarming/.swarming/w/ir/x/w/goroot/pkg/tool/darwin_amd64/go_bootstrap install -pgo=off cmd/asm cmd/cgo cmd/compile cmd/link cmd/preprofile: exit status 1

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 15, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- builder == "x_vulndb-gotip-darwin-amd64_11" && repo == "vulndb" && mode == "build"
2024-05-15 14:51 x_vulndb-gotip-darwin-amd64_11 vulndb@2ff2c865 go@3f7a030e [build] (log)
Building Go cmd/dist using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap. (go1.20.6 darwin/amd64)
Building Go toolchain1 using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
# cmd/vendor/golang.org/x/telemetry/internal/crashmonitor
../../w/goroot/src/cmd/vendor/golang.org/x/telemetry/internal/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts ...debug.CrashOptions) error) as func(*os.File) error value in assignment
go tool dist: FAILED: /Users/swarming/.swarming/w/ir/x/w/goroot/pkg/tool/darwin_amd64/go_bootstrap install -pgo=off cmd/asm cmd/cgo cmd/compile cmd/link cmd/preprofile: exit status 1

watchflakes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 16, 2024
@dmitshur dmitshur added this to the Go1.23 milestone May 16, 2024
@dmitshur
Copy link
Contributor

Fixed by CL 585818.

@dmitshur dmitshur changed the title build: build failure on x_vulndb-gotip-darwin-amd64_11 build: make.bash build failure with "cannot use debug.SetCrashOutput" May 16, 2024
@gopherbot
Copy link
Contributor Author

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
post <- mode == "build" && log ~ "x\/telemetry\/internal\/crashmonitor\/crash_go123\.go:13:19: cannot use debug\.SetCrashOutput \(value of type func\(f \*os\.File, opts \.\.\.debug\.CrashOptions\) error\) as func\(\*os\.File\) error value in assignment"

And the problems were:

script:2.34: invalid quoted string: invalid syntax

See https://go.dev/wiki/Watchflakes for details.

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- mode == "build" && log ~ `x\/telemetry\/internal\/crashmonitor\/crash_go123\.go:13:19: cannot use debug\.SetCrashOutput \(value of type func\(f \*os\.File, opts \.\.\.debug\.CrashOptions\) error\) as func\(\*os\.File\) error value in assignment`
2024-05-15 14:51 x_vulndb-gotip-darwin-amd64_12 vulndb@2ff2c865 go@3f7a030e [build] (log)
Building Go cmd/dist using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap. (go1.20.6 darwin/amd64)
Building Go toolchain1 using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
# cmd/vendor/golang.org/x/telemetry/internal/crashmonitor
../../w/goroot/src/cmd/vendor/golang.org/x/telemetry/internal/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts ...debug.CrashOptions) error) as func(*os.File) error value in assignment
go tool dist: FAILED: /Users/swarming/.swarming/w/ir/x/w/goroot/pkg/tool/darwin_amd64/go_bootstrap install -pgo=off cmd/asm cmd/cgo cmd/compile cmd/link cmd/preprofile: exit status 1
2024-05-15 14:51 x_vulndb-gotip-darwin-amd64_13 vulndb@2ff2c865 go@3f7a030e [build] (log)
Building Go cmd/dist using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap. (go1.20.6 darwin/amd64)
Building Go toolchain1 using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
# cmd/vendor/golang.org/x/telemetry/internal/crashmonitor
../../w/goroot/src/cmd/vendor/golang.org/x/telemetry/internal/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts ...debug.CrashOptions) error) as func(*os.File) error value in assignment
go tool dist: FAILED: /Users/swarming/.swarming/w/ir/x/w/goroot/pkg/tool/darwin_amd64/go_bootstrap install -pgo=off cmd/asm cmd/cgo cmd/compile cmd/link cmd/preprofile: exit status 1
2024-05-15 19:31 x_tools-gotip-darwin-amd64-longtest tools@987af8bd go@3f7a030e [build] (log)
Building Go cmd/dist using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap. (go1.20.6 darwin/amd64)
Building Go toolchain1 using /Users/swarming/.swarming/w/ir/cache/tools/go_bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
# cmd/vendor/golang.org/x/telemetry/internal/crashmonitor
../../w/goroot/src/cmd/vendor/golang.org/x/telemetry/internal/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts ...debug.CrashOptions) error) as func(*os.File) error value in assignment
go tool dist: FAILED: /Users/swarming/.swarming/w/ir/x/w/goroot/pkg/tool/darwin_amd64/go_bootstrap install -pgo=off cmd/asm cmd/cgo cmd/compile cmd/link cmd/preprofile: exit status 1
2024-05-15 19:31 x_tools-gotip-solaris-amd64 tools@987af8bd go@3f7a030e [build] (log)
Building Go cmd/dist using /opt/golang/swarm/.swarming/w/ir/cache/tools/go_bootstrap. (go1.21.0 solaris/amd64)
Building Go toolchain1 using /opt/golang/swarm/.swarming/w/ir/cache/tools/go_bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
# cmd/vendor/golang.org/x/telemetry/internal/crashmonitor
../../w/goroot/src/cmd/vendor/golang.org/x/telemetry/internal/crashmonitor/crash_go123.go:13:19: cannot use debug.SetCrashOutput (value of type func(f *os.File, opts ...debug.CrashOptions) error) as func(*os.File) error value in assignment
go tool dist: FAILED: /opt/golang/swarm/.swarming/w/ir/x/w/goroot/pkg/tool/solaris_amd64/go_bootstrap install -pgo=off cmd/asm cmd/cgo cmd/compile cmd/link cmd/preprofile: exit status 1

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Done
Development

No branches or pull requests

2 participants