Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: document Package fields that should be populated by DriverResponse #67614

Closed
findleyr opened this issue May 23, 2024 · 1 comment
Assignees
Labels
Documentation Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

https://pkg.go.dev/golang.org/x/tools/go/packages#DriverResponse documents that packages should be returned by go/packages drivers, but is unclear about precisely which fields must be populated. (Clearly, some fields cannot be json serialized). There is some discussion of syntax, types, and imports, but this discussion does not enumerate fields.

We should document, perhaps at the field level, which fields are relevant for the driver protocol.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 23, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 23, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/588141 mentions this issue: go/packages: document fields that are part of JSON schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants