Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types, types2: report source line numbers for assertion failures #67932

Closed
griesemer opened this issue Jun 11, 2024 · 3 comments
Closed

go/types, types2: report source line numbers for assertion failures #67932

griesemer opened this issue Jun 11, 2024 · 3 comments
Assignees
@griesemer
Labels
gabywins NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@griesemer
Copy link
Contributor

griesemer commented Jun 11, 2024 •
edited
Loading

The type checkers should report the most recent (or closest) source line number for assertion failures.
See #67872 (comment).
Tracking issue.
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 11, 2024
@griesemer griesemer added this to the Go1.24 milestone Jun 11, 2024
@griesemer griesemer self-assigned this Jun 11, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@griesemer griesemer mentioned this issue Jun 11, 2024
Closed
@rsc
Copy link
Contributor

rsc commented Jun 28, 2024

Looks like #51603 and this issue are the same issue?

@rsc rsc added the gabywins label Jun 28, 2024
@griesemer
Copy link
Contributor Author

griesemer commented Jun 28, 2024 •
edited
Loading

@rsc. Indeed. Closing this as duplicate of #51603.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
gabywins NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.24
Development

No branches or pull requests
3 participants
@rsc @griesemer @gabyhelp