Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liblink: go compiler generate broken name #7327

Closed
mattn opened this issue Feb 14, 2014 · 11 comments
Closed

liblink: go compiler generate broken name #7327

mattn opened this issue Feb 14, 2014 · 11 comments
Milestone

Comments

@mattn
Copy link
Member

mattn commented Feb 14, 2014

What steps will reproduce the problem?
1. put "表.go" on windows japanese locale. (表 is 0x95 0x5c)

What is the expected output?

  表.exe is generated

What do you see instead?

 executable is generated but filename was broken.

Which compiler are you using (5g, 6g, 8g, gccgo)?

 8g

Which operating system are you using?

 Windows7

Which version are you using?  (run 'go version')

  go version devel +e2dd08f26402 Wed Feb 12 12:34:04 2014 +1100 windows/386

Please provide any additional information below.

  https://golang.org/cl/63220043/
  https://golang.org/cl/43150043

  http://go-gyazo.appspot.com/1e62666e56ead7f5.png
  http://go-gyazo.appspot.com/7726ef07295118c2.png
@ianlancetaylor
Copy link
Contributor

Comment 1:

Immediate cause appears to be https://golang.org/cl/43150043 .

Labels changed: added repo-main, release-go1.3, os-windows.

Status changed to Accepted.

@alexbrainman
Copy link
Member

Comment 2:

Is this similar to https://golang.org/issue/3754 ?
Alex

@ianlancetaylor
Copy link
Contributor

Comment 3:

I think this is a specific case of issue #3754, yes.  But I think we've made matters
worse on tip than they were before.

@alexbrainman
Copy link
Member

Comment 4:

Can you explain the "worse" bit in details, please? Thank you.
Alex

@minux
Copy link
Member

minux commented Feb 14, 2014

Comment 5:

i can't think of a good solution to this problem.
this is a dup of 3754, i believe.
we've never supported non-ascii encoding with any C programs
in the toolchain and we rely on cmd/go to correctly handle file paths for
those part of the toolchain.

@alexbrainman
Copy link
Member

Comment 6:

Large part of this will just go away once we have linker written in Go. (I think rsc
said that).
Alex

@minux
Copy link
Member

minux commented Feb 14, 2014

Comment 7:

this problem will be fixed once the compiler and the linker are converted
to Go.
Hopefully it could happen before Go 1.4.

@ianlancetaylor
Copy link
Contributor

Comment 8:

Previously we did not rewrite the file name in this way.  So although
you couldn't use the go tool, you could use 8g/8l to build Go programs
using files with odd names.  Now that no longer works.

@alexbrainman
Copy link
Member

Comment 9:

When you say "rewrite", do you mean "translate '\\' to '/'" ? If so, we always did so.
And it was done in 8l, never was in "go command". You still don't need "go command" to
"translate '\\' to '/'" .
Alex

@ianlancetaylor
Copy link
Contributor

Comment 10:

OK, if we used to do that, then I am mistaken.  I didn't see it
anywhere in the old code.  Sorry for the noise.

@alexbrainman
Copy link
Member

Comment 11:

Making a dup. Let me know, if I am wrong about that.
Alex

Status changed to Duplicate.

Merged into issue #3754.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants