testing: Short() does not work in TestMain() #9825

Activity

1. minux

   added this to the Go1.5 milestone on Feb 10, 2015
2. minux commented on Feb 10, 2015

   

   minux

   on Feb 10, 2015

   Member

   More actions

   TestMain is executed before flag.Parse in (*testing.M).Run.

   I think this is intentional, because it provides a way to modify the
   command line arguments. I you want testing.Short(), then you
   should call flag.Parse() manually in TestMain.

   In conclusion, I think a docs clarification is needed, it's not a bug.
3. minux

   added

   repo-main

   on Feb 10, 2015
4. minux

   changed the title [-]testing: Short() not works on TestMain()[/-] [+]testing: Short() does not work in TestMain()[/+] on Feb 10, 2015
5. hraban commented on Mar 9, 2015

   

   hraban

   on Mar 9, 2015

   More actions

   Please include that testing.Verbose() also doesn't work in TestMain. Came here to post an issue about it, but now I see it's by design.
6. gravis commented on Mar 16, 2015

   

   gravis

   on Mar 16, 2015

   More actions

   I really would like to see changed as well.
   I was planning to use testMain as:

   func TestMain(m *testing.M) {
       // Reset test db before running test.
       // The schema is only imported once for all test
       if !testing.Short() {
           fmt.Println("Initializing test DB for integration test (disable with `go test -short`)")
           initTestDB()
       }
       os.Exit(m.Run())
   }

   And initTestDB() is always run :(
7. minux commented on Mar 16, 2015

   

   minux

   on Mar 16, 2015

   Member

   More actions

   I don't think this is going to change.

   If you want to use testing.Verbose or testing.Short, call flag.Parse in
   TestMain before using them.
8. gravis commented on Mar 16, 2015

   

   gravis

   on Mar 16, 2015

   More actions

   Ok, thanks for the info
9. minux commented on Mar 16, 2015

   

   minux

   on Mar 16, 2015 via email

   Member

   More actions

   I've sent https://golang.org/cl/7604 to add the docs.
10. gravis commented on Mar 16, 2015

    

    gravis

    on Mar 16, 2015

    More actions

    👍 👍
11. minux

    closed this as completedin f63678aon Mar 20, 2015
12. golang

    locked and limited conversation to collaborators on Jun 25, 2016
13. gopherbot

    added

    FrozenDueToAge

    on Jun 25, 2016