Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: jump to bad PC missing good traceback #11656

Closed
rsc opened this issue Jul 10, 2015 · 2 comments
Closed

runtime: jump to bad PC missing good traceback #11656

rsc opened this issue Jul 10, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@rsc
Copy link
Contributor

rsc commented Jul 10, 2015

We're seeing a lot of corruption due to closures being garbage collected and then when the call happens we end up at a non-code PC, which faults. We should fix those bugs, obviously.

But the stack trace should also be able to scan past that, assuming it finds a reasonable caller PC on the stack. That will give us more information about what particular closure is being collected.

See #11644 for an example crash.
@rsc rsc self-assigned this Jul 10, 2015
@rsc rsc added this to the Go1.5 milestone Jul 10, 2015
@gopherbot
Copy link

CL https://golang.org/cl/12026 mentions this issue.

@rsc rsc closed this as completed in 0bcdffe Jul 13, 2015
rsc added a commit that referenced this issue Jul 14, 2015
@rsc
runtime: fix build on non-x86 machines
3290e9c 
Fixes #11656 (again).

Change-Id: I170ff10bfbdb0f34e57c11de42b6ee5291837813
Reviewed-on: https://go-review.googlesource.com/12142
Reviewed-by: Russ Cox <rsc@golang.org>
rsc added a commit that referenced this issue Jul 16, 2015
@rsc
test/fixedbugs: disable issue11656.go on arm64
19916e4 
For #11656.

Change-Id: I8365d33a15419bd0e54f71182ad0994e41650264
Reviewed-on: https://go-review.googlesource.com/12248
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/12762 mentions this issue.

0intro added a commit that referenced this issue Jul 28, 2015
@0intro
runtime: fix x86 stack trace for call to heap memory on Plan 9
68117a9 
Russ Cox fixed this issue for other systems
in CL 12026, but the Plan 9 part was forgotten.

Fixes #11656.

Change-Id: I91c033687987ba43d13ad8f42e3fe4c7a78e6075
Reviewed-on: https://go-review.googlesource.com/12762
Reviewed-by: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Aug 5, 2016
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
2 participants
@rsc @gopherbot