Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgo should insert blank line before package statement #1572

Closed
rogpeppe opened this issue Mar 2, 2011 · 4 comments
Closed

cgo should insert blank line before package statement #1572

rogpeppe opened this issue Mar 2, 2011 · 4 comments
Labels
FrozenDueToAge

Comments

@rogpeppe
Copy link
Contributor

rogpeppe commented Mar 2, 2011 

if you goinstall some package that uses cgo and godoc that package
it shows spurious output.

for example,

% goinstall rog-go.googlecode.com/hg/exp/callback
% godoc rog-go.googlecode.com/hg/exp/callback
PACKAGE

package callback
import "rog-go.googlecode.com/hg/exp/callback"

Created by cgo - DO NOT EDIT
line init.go:1

etc.
@rsc
Copy link
Contributor

rsc commented Mar 2, 2011

Comment 1:

Status changed to HelpWanted.

@rogpeppe
Copy link
Contributor Author

rogpeppe commented Mar 2, 2011

Comment 2:

it's not just the package statement.
global variables get a duplicated entry too.
i would prefer it if all cgo intermediate files were ignored
by godoc - even better if they didn't clutter up the
package's directory, for example by producing them
somewhere in the _obj directory.
might a change to that effect be accepted?

@rsc
Copy link
Contributor

rsc commented Mar 2, 2011

Comment 3:

sure, a change to put them in _obj works for me.

@rsc
Copy link
Contributor

rsc commented Mar 2, 2011

Comment 4:

This issue was closed by revision 9704d4e.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogpeppe @rsc @gopherbot