Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: unable to listen on all interfaces #1854

Closed
bradfitz opened this issue May 20, 2011 · 3 comments
Closed

regression: unable to listen on all interfaces #1854

bradfitz opened this issue May 20, 2011 · 3 comments

Comments

@bradfitz
Copy link
Contributor

Mikioh,

I think this CL might have broken:

  http.ListenAndServe(":8080", handler)

Didn't that listen on 127.0.0.1:8080 and [::1]:8080 before?  Or am I misremembering? 
How's that supposed to work?

- Brad

On Mon, May 16, 2011 at 2:03 PM, <rsc@golang.org> wrote:
*** Submitted as
http://code.google.com/p/go/source/detail?r=a93e817f273e ***

net: protocol family adaptive address family selection

This CL will help to make an adaptive address family
selection possible when an any address family, vague
network string such as "ip", "tcp" or "udp" is passed
to Dial and Listen API.

Fixes issue #1769.
@bradfitz
Copy link
Contributor Author

Comment 1:

>   http.ListenAndServe(":8080", handler)
> Didn't that listen on 127.0.0.1:8080 and [::1]:8080 before?  Or am I
> misremembering?  How's that supposed to work?
Here is my updated expectation, with "no address/name string" case.
wildcard listening test cases:
"tcp", ":31101"                         // FIXME: CL4438066's bug
"tcp", "0.0.0.0:31102"                  // ipv4-only
"tcp", "[::ffff:0.0.0.0]:31103"         // ipv4-only
"tcp", "[::]:31104"                     // depends on your system
"tcp4", ":31105"                        // ipv4-only
"tcp4", "0.0.0.0:31106"                 // ipv4-only
"tcp4", "[::ffff:0.0.0.0]:31107"        // ipv4-only
"tcp6", ":31108"                        // depends on your system
"tcp6", "[::ffff:0.0.0.0]:31109"        // depends on your system
"tcp6", "[::]:31110"                    // depends on your system
result of release.r57 on v6only=0 system:
listening looks okay: [::]:31101        // ipv6 or both
listening looks okay: [::]:31102        // ipv6 or both
listening looks okay: [::]:31103        // ipv6 or both
listening looks okay: [::]:31104        // ipv6 or both
listening looks okay: 0.0.0.0:31105     // ipv4
listening looks okay: 0.0.0.0:31106     // ipv4
listening looks okay: 0.0.0.0:31107     // ipv4
listening looks okay: [::]:31108        // ipv6 or both
listening looks okay: [::]:31109        // ipv6 or both
listening looks okay: [::]:31110        // ipv6 or both
result of tip on v6only=0 system:
listening looks okay: 0.0.0.0:31101     // ipv4
listening looks okay: 0.0.0.0:31102     // ipv4
listening looks okay: 0.0.0.0:31103     // ipv4
listening looks okay: [::]:31104        // ipv6 or both
listening looks okay: 0.0.0.0:31105     // ipv4
listening looks okay: 0.0.0.0:31106     // ipv4
listening looks okay: 0.0.0.0:31107     // ipv4
listening looks okay: [::]:31108        // ipv6 or both
listening looks okay: [::]:31109        // ipv6 or both
listening looks okay: [::]:31110        // ipv6 or both
-- Mikio

@mikioh
Copy link
Contributor

mikioh commented May 20, 2011

Comment 2:

Here is a new patch run result, what I expected in CL4438066.
result of tip w/ patch on v6only=0 system:
listening looks okay: [::]:31101        // ipv6 or both
listening looks okay: 0.0.0.0:31102 // ipv4
listening looks okay: 0.0.0.0:31103 // ipv4
listening looks okay: [::]:31104        // ipv6 or both
listening looks okay: 0.0.0.0:31105 // ipv4
listening looks okay: 0.0.0.0:31106 // ipv4
listening looks okay: 0.0.0.0:31107 // ipv4
listening looks okay: [::]:31108        // ipv6 or both
listening looks okay: [::]:31109        // ipv6 or both
listening looks okay: [::]:31110        // ipv6 or both

@bradfitz
Copy link
Contributor Author

Comment 3:

This issue was closed by revision 8c6dc5f.

Status changed to Fixed.

@bradfitz bradfitz self-assigned this May 22, 2011
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants