Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: document the hint for make(map) better #19903

Closed
gruszczy opened this issue Apr 10, 2017 · 7 comments
Closed

spec: document the hint for make(map) better #19903

gruszczy opened this issue Apr 10, 2017 · 7 comments
Labels
Documentation FrozenDueToAge Proposal Proposal-Accepted
Milestone
Go1.9

Comments

@gruszczy
Copy link
Contributor

What version of Go are you using (go version)?

go version devel +2e108a1be6 Tue Apr 4 11:55:55 2017 -0700 darwin/amd64

In https://go-review.googlesource.com/c/40113/ Rob Pike asked to add documentation about reflect.MakeMapWithSize.
@odeke-em odeke-em changed the title Provide documentation about usage of reflect.MakeMapWithSize reflect: document MakeMapWithSize's capacity usage and quirks Apr 10, 2017
@dsnet dsnet added this to the Go1.9 milestone Apr 10, 2017
@robpike
Copy link
Contributor

robpike commented Apr 10, 2017

This might also require words in the spec, so I'm promoting this to an issue.

@robpike robpike changed the title reflect: document MakeMapWithSize's capacity usage and quirks proposal: document better the hint for make(map) Apr 10, 2017
@rsc
Copy link
Contributor

rsc commented Apr 10, 2017

I sent a CL. The lack of documentation in the spec is intentional. It is a hint, not a precisely documented value. I also commented on CL 40113 - that code is assuming far more than is warranted.

@rsc
Copy link
Contributor

rsc commented Apr 10, 2017

CL is https://go-review.googlesource.com/40230

@gopherbot
Copy link

CL https://golang.org/cl/40230 mentions this issue.

@rsc
Copy link
Contributor

rsc commented Apr 10, 2017

@griesemer will send a CL with a spec change. Then we'll copy the spec text into reflect.

@rsc rsc changed the title proposal: document better the hint for make(map) spec: document the hint for make(map) better Apr 10, 2017
@rsc rsc changed the title spec: document the hint for make(map) better proposal: spec: document the hint for make(map) better Apr 10, 2017
@rsc rsc changed the title proposal: spec: document the hint for make(map) better spec: document the hint for make(map) better Apr 10, 2017
@gopherbot
Copy link

CL https://golang.org/cl/40393 mentions this issue.

This was referenced Apr 11, 2017
Closed
Closed
gopherbot pushed a commit that referenced this issue Apr 13, 2017
@griesemer
spec: clarify size hint for make of maps
b0e5a0c 
For #19903.

Change-Id: Ib28d08d45bfad653bcc1446f160b7b4a485529af
Reviewed-on: https://go-review.googlesource.com/40393
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/46270 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge Proposal Proposal-Accepted
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
5 participants
@rsc @gruszczy @robpike @dsnet @gopherbot