Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofmt doesn't understand literal constructors in argument lists #352

Closed
jackpal opened this issue Nov 28, 2009 · 4 comments
Closed

gofmt doesn't understand literal constructors in argument lists #352

jackpal opened this issue Nov 28, 2009 · 4 comments

Comments

@jackpal
Copy link
Contributor

jackpal commented Nov 28, 2009

1) pull and build go (On OSX 10.5 if it matters.)
2) gofmt gotrace.go

gotrace.go:164:21: expected ')', found '{'
gotrace.go:166:9: expected operand, found 'return'
gotrace.go:168:5: expected declaration, found 'IDENT' litColor
gotrace.go:169:5: expected declaration, found 'IDENT' totalColor
gotrace.go:170:5: expected declaration, found 'return'
gotrace.go:171:1: expected declaration, found '}'

The line that causes the problem is:

    if intersect(Ray{p, vec3mulf(s.light, -1.0)}, s.g).distance < infinity {

It's the 'Ray{...}' that's causing the problem.

Attachments:

  1. gotrace.go (9023 bytes)
@rsc
Copy link
Contributor

rsc commented Nov 29, 2009

Comment 1:

Owner changed to g...@golang.org.

Status changed to Accepted.

@griesemer
Copy link
Contributor

Comment 2:

Status changed to Started.

@griesemer
Copy link
Contributor

Comment 3:

This issue was closed by revision f3e0f21.

Status changed to Fixed.

Merged into issue #-.

@griesemer
Copy link
Contributor

Comment 4:

Issue #344 has been merged into this issue.

@jackpal jackpal added the fixed label Nov 29, 2009
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants