-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/release: linux-s390x-crosscompile builder fails to compile Go 1.16 #43090
Comments
This seems related to Go 1.4.3 being used as the bootstrap version. I can reproduce on a Linux machine with:
So the question is: is it unexpected that Go 1.16 no longer bootstraps with Go 1.4.3 (unlike Go 1.15.x, which does)? Or should the cross-compile builder be updated to use a newer bootstrap version? |
The current Go toolchain should build with a Go 1.4 bootstrap. (I think @mdempsky has suggested bumping that minimum version higher, but I don't see a concrete proposal to do so yet.) |
From the error message, I believe you will find that this failure bisects to CL 233317, and the fix may be to update the rules at |
Hi @bcmills and @dmitshur, thanks for the information and investigation. Yea, from our side, we also found that CL 233317 is the issue.
Thanks, I will try this fix. Another thing I noticed is that if I run
|
Another option is to change the aux type of SLDconst and friends to |
Hi,
This does look to fix the compilation issue. I am now able to build master with go1.10.4 with updated rules applied on s390x. We are trying to cross-compile with go1.4.3 and will report back once we have the results.
Thanks, I had a try with this approach, it looks like uint8 is not a supported auxint? Adding UInt8 to the function |
That may be. Adding it shouldn't be hard (but may be a bit tedious). |
Hi,
Both @rajaskakodkar and I have tested that this fixes the cross-compilation problem listed in this issue.
|
Thanks, I have explored this approach a bit more. I seem to get it working, but it does need a bit more changes. I am planning to send two CLs soon with both approaches and see which one could fit better. |
Thank you @ruixin-bao and @rajaskakodkar. Please include a "Fixes #43090" (or "For #43090") line in the CLs when you send them, so that this issue is updated when they become available for review. |
Change https://golang.org/cl/277078 mentions this issue: |
Change https://golang.org/cl/277079 mentions this issue: |
The
linux-s390x-crosscompile
builder is used in the release process to build s390x.tar.gz release archives. It currently fails when building Go 1.16 (with go1.4.3 linux/amd64 as the bootstrap version).This can be reproduced if your account has permissions needed to run
releasebot
(documented here) with:In contrast, it works okay on release-branch.go1.15:
The problem may be on the side of the builder, or in the tree (or both). Thoughts?
CC @golang/release, @randall77, @ianlancetaylor, @ruixin-bao, @rajaskakodkar.
The text was updated successfully, but these errors were encountered: